New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists at "Manage Sector Identifiers" pages are skewed #1027

Closed
aliaksander-samuseu opened this Issue Jul 2, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@aliaksander-samuseu

aliaksander-samuseu commented Jul 2, 2018

Environment:
Ubuntu 14.04, Gluu CE 3.1.3

Lists at "OpenID Connect -> Manage Sector Identifiers -> Add Sector Identifier" have the same issue as described in this report:
sector_id_page_list_bug

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Jul 12, 2018

image

@shekhar16 shekhar16 closed this Jul 12, 2018

yurem added a commit that referenced this issue Jul 18, 2018

Merge pull request #1036 from GluuFederation/#1027
#1027 : alignment for link and cross button.
@natt-tester

This comment has been minimized.

natt-tester commented Aug 10, 2018

Agreed, it's done.

@natt-tester

This comment has been minimized.

natt-tester commented Sep 6, 2018

@shekhar16, I see now that it's better to make the rows a bit longer -- preferably as long as the ones in the first column -- to avoid situations like this one:

ubuntu14_rc2_longer-table

Tested with RC2 in Ubuntu 14/Firefox.

@natt-tester natt-tester reopened this Sep 6, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 6, 2018

Before
image

After

image

@syntrydy syntrydy closed this Sep 6, 2018

syntrydy pushed a commit that referenced this issue Sep 6, 2018

syntrydy added a commit that referenced this issue Sep 6, 2018

Merge pull request #1185 from /issues/1027
Fix space in sector identifier form #1027

syntrydy pushed a commit that referenced this issue Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment