New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate contact values entered in openID clients form #1051

Closed
jgomer2001 opened this Issue Jul 25, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@jgomer2001
Contributor

jgomer2001 commented Jul 25, 2018

According to spec:

contacts: Array of e-mail addresses of people responsible for this Client.

When pressing the "add contact" button at the bottom, one can enter any string, we should validate it is an e-mail actually:
not_an_email

@jgomer2001 jgomer2001 added this to the 3.1.4 milestone Jul 25, 2018

@syntrydy syntrydy self-assigned this Aug 1, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 1, 2018

I added a contact validator that ignore pick up just the valid email but that occurs when the save button is pressed. It is correct for you @jgomer2001 ?

syntrydy pushed a commit that referenced this issue Aug 1, 2018

jgomer2001 added a commit that referenced this issue Aug 2, 2018

@syntrydy syntrydy closed this Aug 3, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Sep 6, 2018

It works as @syntrydy described: any string can be saved as an e-mail address, but upon clicking Add/Update it's removed and an error message is displayed:

mail1

mail2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment