New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move captcha setting to "Manage Authentication" into new tab #1072

Closed
yurem opened this Issue Aug 8, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@yurem
Contributor

yurem commented Aug 8, 2018

We need to move fields Recaptcha Site Key' and Recaptcha Secret Key` to "Manage Authentication" into new tab Also we need to add checkbox to enable/disable it.

@yurem yurem added this to the 3.1.4 milestone Aug 8, 2018

shekhar16 added a commit to GluuFederation/oxCore that referenced this issue Aug 12, 2018

GluuFederation/oxTrust#1072 : added
authenticationRecaptchaEnabled on manage authentication page.
@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Aug 12, 2018

image

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Aug 12, 2018

we already had these fields on manage registration page. So do we need to remove these text fields from manage registration page.
image

yurem added a commit that referenced this issue Aug 14, 2018

Merge pull request #1076 from GluuFederation/#1072
#1072 : added recaptcha tab on manage autheticate page.

yurem added a commit to GluuFederation/oxCore that referenced this issue Aug 14, 2018

Merge pull request #86 from GluuFederation/#1072
GluuFederation/oxTrust#1072 : added authenticationRecaptchaEnabled on manage authentication page.

yurem added a commit to GluuFederation/oxCore that referenced this issue Aug 14, 2018

GluuFederation/oxTrust#1072 : added
authenticationRecaptchaEnabled on manage authentication page.

@shekhar16 shekhar16 closed this Aug 21, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Sep 10, 2018

@shekhar16, if I understand it correctly, recaptcha should be moved to "Manage Authentication". Now it is there as Captcha Site Key and Captcha Secret Key, so please change the names.

Also, Recaptcha fields are still present in the Manage Registration Page, so please remove them:

recaptcha

captcha

@natt-tester natt-tester reopened this Sep 10, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Sep 10, 2018

@natt-tester since an organization might want to use Captcha's on many pages, e.g. registration, login, etc. do you think we should put the Captcha configuration fields in a more top level page, like Organization Configuration and then offer a checkbox on configuration pages, like Authentication and Registration to enable / disable captcha for that specific page?

@natt-tester

This comment has been minimized.

natt-tester commented Sep 12, 2018

@natt-tester since an organization might want to use Captcha's on many pages, e.g. registration, login, etc. do you think we should put the Captcha configuration fields in a more top level page, like Organization Configuration and then offer a checkbox on configuration pages, like Authentication and Registration to enable / disable captcha for that specific page?

@willow9886 Yes, I think it's a good idea, it will be clearer for the user. @shekhar16, could you implement it?

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Sep 12, 2018

@natt-tester @willow9886 the captcha keys would be same.So we can add enable / disable check boxes for different functionality pages like registration, login, etc.

shekhar16 added a commit that referenced this issue Sep 16, 2018

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Sep 16, 2018

Captcha site and key text-boxes are removed from manage registration and authentication configuration page.
only on json configuration page captcha site and key text boxes are visible.here is snapshots
Manage Authentication page:
image

Manage registration page .
image

json configuration :

image

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Sep 18, 2018

@shekhar16 why in manage authentication is the field Enable Captcha... and in manage registration the field is Diasble Captcha... ? What is the purpose of framing the same question differently in two places?

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Sep 20, 2018

@willow9886 checkbox on authentication tab will enable the captcha on passwordreset functionality and manage registration checkbox will enable it on registration page.

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Sep 20, 2018

I changed the label of checkbox to make label consistent in manage authentication and registration
here is screenshot.
image

yurem added a commit that referenced this issue Sep 20, 2018

Merge pull request #1245 from GluuFederation/#1072morechanges
#1072 : removed unwanted captcha site and key,changed label

shekhar16 added a commit that referenced this issue Sep 21, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 23, 2018

it is okay. Cool @shekhar16

@syntrydy syntrydy closed this Sep 23, 2018

yurem added a commit that referenced this issue Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment