New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError #1080

Closed
natt-tester opened this Issue Aug 13, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@natt-tester

natt-tester commented Aug 13, 2018

The most recent 3.1.4 has an uncaught TypeError in OpenID Connect -> Clients -> Add Client -> Client's Registration Expires. It's impossible to set the expiration date:

screen shot 2018-08-13 at 11 11 18

@natt-tester natt-tester added the bug label Aug 13, 2018

@natt-tester natt-tester added this to the 3.1.4 milestone Aug 13, 2018

@syntrydy syntrydy self-assigned this Aug 13, 2018

syntrydy pushed a commit that referenced this issue Aug 13, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 13, 2018

@natt-tester please check and close

yurem added a commit that referenced this issue Aug 14, 2018

yurem added a commit that referenced this issue Aug 14, 2018

Merge pull request #1084 from /issues/1080
Fix expiration date component #1080

@syntrydy syntrydy closed this Aug 14, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Sep 5, 2018

@syntrydy, there's no error anymore, but the date picker needs improvement: to avoid misconfiguration issues, it should be impossible to set an expiration date in the past.

@natt-tester natt-tester reopened this Sep 5, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 5, 2018

it should be impossible to set an expiration date in the past. Why, if you set a past date as expiration date for a client then it is useless.

@natt-tester

This comment has been minimized.

natt-tester commented Sep 5, 2018

Closed and done, but raised an enhancement issue in #1179.

@natt-tester natt-tester closed this Sep 5, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Sep 5, 2018

it should be impossible to set an expiration date in the past. Why, if you set a past date as expiration date for a client then it is useless.

I raised the same question on #1179.

If setting a past expiration date == delete, then the user should simply delete the client.

As far as I can tell, allowing clients or users to set an expiration date in the past simply introduces confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment