New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email validation in System Configuration #1090

Closed
natt-tester opened this Issue Aug 14, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@natt-tester

natt-tester commented Aug 14, 2018

It's not a required field, but now any string can be entered and saved as the email address. Please add validation to the field.

email_validation

@natt-tester natt-tester added this to the 3.1.4 milestone Aug 14, 2018

@natt-tester natt-tester changed the title from Email validation in system configuration to Email validation in System Configuration Aug 14, 2018

syntrydy pushed a commit that referenced this issue Aug 14, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 14, 2018

image

@syntrydy syntrydy self-assigned this Aug 14, 2018

yurem added a commit that referenced this issue Aug 14, 2018

Merge pull request #1095 from /issues/1090
Fix mail validation #1090

yurem added a commit that referenced this issue Aug 14, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Aug 14, 2018

I would update the text to:

Please provide a valid email address.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 16, 2018

image

syntrydy pushed a commit that referenced this issue Aug 16, 2018

@syntrydy syntrydy closed this Aug 16, 2018

yurem added a commit that referenced this issue Aug 17, 2018

Merge pull request #1104 from /issues/1090
Ox trust/issues/1090

yurem added a commit that referenced this issue Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment