New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder instead of Build Number #1091

Closed
natt-tester opened this Issue Aug 14, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@natt-tester

natt-tester commented Aug 14, 2018

In Configuration -> Organization Configuration -> OxTrust Settings there's a placeholder instead of the correct value:

placeholder

Tested in Ubuntu 14.04, firefox.

@natt-tester natt-tester added the bug label Aug 14, 2018

@natt-tester natt-tester added this to the 3.1.4 milestone Aug 14, 2018

@natt-tester natt-tester changed the title from Placeholder instead of Build number to Placeholder instead of Build Number Aug 14, 2018

@earezki earezki self-assigned this Aug 14, 2018

@earezki

This comment has been minimized.

Contributor

earezki commented Aug 14, 2018

This env var exists only for Jenkins builds:
image

However, the build date and the build number seem to be only useful for devs and have no use to the end user. Hence, I think we should remove them from the UI.

earezki added a commit to earezki/oxTrust that referenced this issue Aug 14, 2018

yurem added a commit that referenced this issue Aug 15, 2018

Merge pull request #1098 from earezki/oxTrust/issues/#1091
#1091 remove buildDate and buildNumber from organization oxTrustSettings

@earezki earezki closed this Aug 15, 2018

@natt-tester natt-tester self-assigned this Aug 16, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Aug 16, 2018

@earezki, that's a good way to solve this issue. I'll check it in the new package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment