New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error message #1092

Closed
natt-tester opened this Issue Aug 14, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@natt-tester

natt-tester commented Aug 14, 2018

Steps:

  1. Go to Organization -> Cache Refresh
  2. Immediately click either Update or Update&Validate Script

Expected: As a user I want to be taken to the problematic view/tab if the update fails.

Actual: The user sees 4 error messages with typos, but the necessary fields are not present on the shown tab.
It can be confusing, so the best solution would be to take the user to the mentioned fields/tab. For better UX we should unify and implement this behavior. Also, please correct the typo everywhere in the code:
typo1

@natt-tester natt-tester added the bug label Aug 14, 2018

@natt-tester natt-tester added this to the 3.1.4 milestone Aug 14, 2018

@earezki earezki self-assigned this Aug 14, 2018

@earezki

This comment has been minimized.

Contributor

earezki commented Aug 15, 2018

This makes sens,
But, the issue is that we're updating every tab when we hit update (for all the views), means we can have validation errors in mixed tabs.
To test, remove the base dn in the Inum LDAP Server tab and hit update:
image
This won't be an issue in the new api.
For now, I propose to only fix the typo (Good catch BTW, thx).

earezki added a commit to earezki/oxTrust that referenced this issue Aug 15, 2018

@earezki

This comment has been minimized.

Contributor

earezki commented Aug 15, 2018

What we may do is to add an indication on the fields that are not valid:
image
But this would be an enhancement for another release.

yurem added a commit that referenced this issue Aug 15, 2018

yurem added a commit that referenced this issue Aug 15, 2018

@earezki earezki closed this Aug 15, 2018

@natt-tester natt-tester self-assigned this Aug 16, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Aug 16, 2018

@earezki, I see what you mean. The enhancement will be a most welcome change, but I guess we need more time to carefully plan it.

@natt-tester

This comment has been minimized.

natt-tester commented Sep 5, 2018

Confirmed, the typo is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment