New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oxTrust Auditing Log Fixes #1146

Closed
afroDC opened this Issue Aug 27, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@afroDC

afroDC commented Aug 27, 2018

+USER @!A56E.BF38.1670.AD63!0001!14E9.47F0!0000!D668.1456.E8E9.F171 ADDED BY USER Default Admin User FROM IP ADDRESS 10.0.0.1 ON Mon 08-27-2018 22:13:12 +

The INUM along with the displayName should be displayed for readability.

Also the timestamps should match the formatting of other logs in Gluu Server:

2018-08-27 21:39:12,182 INFO  [oxAuthScheduler_Worker-4] [org.xdi.service.PythonService$PythonLoggerOutputStream] (PythonService.java:239) - RPT Policy. Initialized successfully

In the case of oxtrust_audit.log:

YYYY-MM-DD HH:MM:SS,sss [USER] $INUM $displayName ADDED by user $user FROM IP Address $IP ADDRESS
2018-08-27 21:39:12,182 [USER] @!A56E.BF38.1670.AD63!0001!14E9.47F0!0000!D668.1456.E8E9.F171 "John" ADDED by user Default Admin User FROM IP Address 10.0.0.1

@afroDC afroDC added the enhancement label Aug 27, 2018

@afroDC afroDC added this to the 3.1.4 milestone Aug 27, 2018

syntrydy pushed a commit that referenced this issue Aug 28, 2018

@syntrydy syntrydy closed this Aug 28, 2018

syntrydy pushed a commit that referenced this issue Aug 28, 2018

yurem added a commit that referenced this issue Aug 28, 2018

Merge pull request #1155 from /issues/1146
Enhacement audit log #1146

yurem added a commit that referenced this issue Aug 28, 2018

@sahiliamsso

This comment has been minimized.

Contributor

sahiliamsso commented Sep 11, 2018

Can we replace "**" with double quotes for better readability and parsing.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment