New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird password reset message #1152

Closed
natt-tester opened this Issue Aug 28, 2018 · 12 comments

Comments

Projects
None yet
4 participants
@natt-tester

natt-tester commented Aug 28, 2018

It's possible to get this weird message when you click on the reset link in the email when you've already used it:

ubuntu16_gserver3 1 4_wrong_password_success

Ideally, upon clicking the already used link we should have a message and a field to re-enter your e-mail to generate a new link:

"Oops!
This link has already been used to reset your password.
Re-enter your e-mail to generate a new link."

But for now we can skip the field part and just change the strings.

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Aug 28, 2018

@natt-tester how about :

Oops! This link has expired. Please try again.

@natt-tester

This comment has been minimized.

natt-tester commented Aug 28, 2018

@willow9886 yes, that will work for both the expired and already used e-mail. Btw, how long is the e-mail valid?

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 31, 2018

image

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 31, 2018

I think it is better than Oops ..... The user can generate new link directly if needed.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 31, 2018

image

syntrydy pushed a commit that referenced this issue Aug 31, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 31, 2018

image

@syntrydy syntrydy closed this Aug 31, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Aug 31, 2018

@syntrydy can you update the content?

The reset link is no more valid....

This can be improved.

You can simply say:

The reset link is no longer valid. Re-enter your email to generate a new link.

yurem added a commit that referenced this issue Aug 31, 2018

yurem added a commit that referenced this issue Aug 31, 2018

@sahiliamsso

This comment has been minimized.

Contributor

sahiliamsso commented Sep 11, 2018

Not able to reset user password, After clicking on the link, It redirects to change password screen but when I hit Update Password, see this error
image

@sahiliamsso sahiliamsso reopened this Sep 11, 2018

@sahiliamsso

This comment has been minimized.

Contributor

sahiliamsso commented Sep 11, 2018

As the message says “The reset link is no more valid.It has already been used to reset your password or it has expired. Re-enter your e-mail to generate a new link.”

What is the default expiry time? Can it be configured in oxtrust (say 15min/1hr/24hrs)
I don’t see it mentioned in the password reset email.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 11, 2018

The password reset is working as expected in the current code.
Note that I use the issue title and his description to fix it. So think like specified the expiration time for reset link is a separate issue.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 11, 2018

@syntrydy syntrydy closed this Sep 11, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Sep 25, 2018

We need to improve the messages. I think we agreed on pop-ups with success messages "Reset password e-mail has been sent" and "Reset password successful" on the login screen, but we don't have them in RC7.
After changing the password, the user is redirected to the login page. The messages are visible only when you go back to the reset password page, which isn't good:

no_longer

- please change "more" to "longer"

invalid_link

- disable the first message with the caps

@natt-tester natt-tester reopened this Sep 25, 2018

syntrydy pushed a commit that referenced this issue Sep 25, 2018

syntrydy added a commit that referenced this issue Sep 25, 2018

Merge pull request #1260 from /issues/1152
Fix some smal issues #1152

syntrydy pushed a commit that referenced this issue Sep 25, 2018

@syntrydy syntrydy closed this Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment