New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication graph improvement #1196

Closed
mzico opened this Issue Sep 10, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@mzico
Contributor

mzico commented Sep 10, 2018

Right now, graph and data below graph is showing last 7 day activity.
A customer suggested to include information of 'Total login' instead of "Last 7 days statistics" graph ( or, along with "Last 7 days statistics" [ red banner ].

Do you think it's possible?
protected_answer_4755_skewed_statistics_9-10-2018

@mzico mzico added the enhancement label Sep 10, 2018

@mzico mzico added this to the 3.1.5 milestone Sep 10, 2018

@tcerise

This comment has been minimized.

tcerise commented Sep 10, 2018

This should help clarify what this request was referencing. Day 8 seems to be an accumulation of all previous days login attempts, and should not be part of the 7 day graph. I also added in moving the "Last 7 days statistics header above the graph since it makes more sense, to me, at the top when reflecting on it further.

image

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 9, 2018

image

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 9, 2018

@tcerise is it as you want it to be?
@mzico is that correct for you?

syntrydy pushed a commit that referenced this issue Oct 9, 2018

syntrydy added a commit that referenced this issue Oct 9, 2018

Merge pull request #1299 from /issues/1196
Authentication graph improvement #1196

syntrydy pushed a commit that referenced this issue Oct 9, 2018

@tcerise

This comment has been minimized.

tcerise commented Oct 9, 2018

Yes, that is very nice. The 7 day graph is a good representation of the last week's success/failed login attempts. The totals at the bottom should represent the totals since the system was started, or the last time the counters were reset to reflect the actual total numbers and not simply the weeks numbers shown in the graph. It currently does show the sum totals, it is just that the graph itself is skewed by them.

Does that make sense? Thanks.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 9, 2018

@tcerise About this The totals at the bottom should represent the totals since the system was started i think we can summarized that to The total 365 days(one year) authentication requests

Right now we don't want to create a now entry in Ldap just to store the last system restart date. Also showing the last 365 days authentication days is a pretty decent amount of data.
Make sense?

@tcerise

This comment has been minimized.

tcerise commented Oct 9, 2018

That sounds fine to me. Thanks.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 10, 2018

image

syntrydy added a commit that referenced this issue Oct 10, 2018

Merge pull request #1300 from /issues/1196
Fix issue Authentication graph improvement #1196

@syntrydy syntrydy closed this Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment