New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement : oxTrust automatically switch to another tab on update action. #1219

Closed
yuriyz opened this Issue Sep 14, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@yuriyz
Contributor

yuriyz commented Sep 14, 2018

Steps

  1. Go to "Configuration" -> "JSON Configuration"
  2. Select "oxAuth Configuraiton" tab.
  3. Change any value and click Update button.
    Result: page is refreshed and "oxTrust Configuration" tab is selected. If user wish to double check whether value is really saved then he/she needs to select "oxAuth Configuraiton" tab again and navigate to changed value.
    Expected result: as minimum I would expect no automatic switch of the tabs. Ideally page should stay on same position as it was during Update click. So user just see message "oxAuth configuration is updated successfully."

@yuriyz yuriyz added the enhancement label Sep 14, 2018

@yuriyz yuriyz added this to the 4.0 milestone Sep 14, 2018

@syntrydy syntrydy self-assigned this Oct 29, 2018

@syntrydy syntrydy modified the milestones: 4.0, 3.1.5 Oct 30, 2018

syntrydy pushed a commit that referenced this issue Oct 30, 2018

syntrydy added a commit that referenced this issue Oct 30, 2018

Merge pull request #1324 from /issues/1219
Ox trust/issues/1219

@syntrydy syntrydy closed this in f4e47b3 Oct 30, 2018

@syntrydy syntrydy reopened this Oct 30, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 30, 2018

@yuriyz, enhancement added

@syntrydy syntrydy closed this Oct 30, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Dec 16, 2018

Expected result: as minimum I would expect no automatic switch of the tabs.

The requirement is met. DONE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment