New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register page pop-up displayed for another user (the same browser) #1269

Closed
natt-tester opened this Issue Sep 27, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@natt-tester

natt-tester commented Sep 27, 2018

Steps:

  1. Go to the user registration page
  2. Complete the form with new credentials and click Register

Expected: On the same page there is a pop-up saying you've registered successfully, but you're inactive.
Actual: There's no pop-up, the admin sees it when they log in. The same behavior occurs for password reset.

@natt-tester natt-tester added this to the 3.1.4 milestone Sep 27, 2018

@natt-tester natt-tester changed the title from Register page pop-up displayed for admin to Register page pop-up displayed for another user (the same browser) Sep 27, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 27, 2018

After user registration, a message is added to facesMessages for displayed, there is also to redirection to login page. The message is coming from oxTrust(registration page) and the redirection goes to oxauth(login) page, hence the messages can't cross component. It is then display when you login and when back to oxtrust(home page)

@natt-tester

This comment has been minimized.

natt-tester commented Sep 28, 2018

I think it's solved: now the user is redirected to see their inactive profile. The pop-up is there:

register

However, when the user clicks on the dropdown Profile/Language/Logo, they are redirected to the login page. @willow9886, is that acceptable behavior?

Also, for password reset the popup about the reset password is visible after the user logs in with the new password, so it's a bit illogical. @yurem, can we change that too?

@natt-tester natt-tester reopened this Sep 28, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Sep 28, 2018

@natt-tester

However, when the user clicks on the dropdown Profile/Language/Logo, they are redirected to the login page.

Its not ideal behavior. It puts them in a loop with no clear objective. I think we should simply display a message saying:

Your account has been disabled. If you believe this is an error, contact your system administrator for assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment