New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo inconsistency #1270

Closed
natt-tester opened this Issue Sep 27, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@natt-tester

natt-tester commented Sep 27, 2018

After uploading a custom logo to /opt/gluu/jetty/oxauth/custom/static/img, it appears on the left on the login page, but is centered in the majority of other public-facing pages.

Shouldn't we choose one convention and stick to it?

login_logo

error_logo

passportpostlogin

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 27, 2018

What is the problem?

@natt-tester

This comment has been minimized.

natt-tester commented Sep 27, 2018

@syntrydy, now that we've changed the design of the other public-facing pages, I've noticed that the not-centered logo really stands out. Should we keep it this way?

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 27, 2018

That was by design, the logo for login page is left-align and others logo are centered

@natt-tester

This comment has been minimized.

natt-tester commented Sep 27, 2018

This is why I've added also @willow9886 to this question, maybe we should consider redesign in the future? Especially the passportpostlogin page looks a bit random now...

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 27, 2018

Agreed, we shouldn't be doing UX, normally design is provide by UX team and we just implement as it is.
I guess we don't have UX team. Without UX design we are going to say all time this is good, this isn't, etc.
Meanwhile we have to do with what we have at hand.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 27, 2018

@natt-tester there is a task to enhance logo customization, that task has been schedule for 3.1.5.
GluuFederation/oxAuth#912

I suggest to let all logo as they are now. In 3.1.5 we can improve them as we want.

@syntrydy syntrydy closed this Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment