New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenID Scope selection UX #1292

Closed
nynymike opened this Issue Oct 5, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@nynymike
Contributor

nynymike commented Oct 5, 2018

It takes too long to select OpenID Scopes, you have to search, select, and hit ok. It would be better if there was an oxTrust JSON property called "defaultOpenIDClientScopes" with default values "openid, profile, email" which would automatically show when you hit the add scopes button in the client form. It would also give customers the ability to add add'l scopes if they commonly use them.

@nynymike nynymike added the enhancement label Oct 5, 2018

@nynymike nynymike added this to the 3.1.5 milestone Oct 5, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Oct 5, 2018

Also give users ability to add multiple scopes at the same time, e.g. click scope 1, scope 2, scope 3, etc., then click: add

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 23, 2018

image

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Oct 23, 2018

@nynymike i think the solution provide above is better in that:

  • We don't have to create new entry in LDAP just to store defaultOpenIDClientScopes
  • Our upgrade script stay unchanged as there is no new LDAP entry/updated entry
  • In real scenario we don't have enough scopes and even if we have enough, the scroll bar help to pick them with ease.

syntrydy pushed a commit that referenced this issue Oct 23, 2018

syntrydy added a commit that referenced this issue Oct 23, 2018

Merge pull request #1309 from /issues/1292
Improve OpenID Scope selection UX #1292

syntrydy pushed a commit that referenced this issue Oct 23, 2018

@syntrydy syntrydy closed this Oct 24, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Dec 11, 2018

@syntrydy, I think the scroll is gone from the scopes list -- my newly created scope cannot be found on the list when you want to add it to an OIDC client. Also all 10 < scopes are missing:

obraz

scopes

Please look into it.

@natt-tester natt-tester reopened this Dec 11, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Dec 11, 2018

image

syntrydy pushed a commit that referenced this issue Dec 11, 2018

syntrydy added a commit that referenced this issue Dec 11, 2018

Merge pull request #1399 from /issues/1292
Improve OpenID Scope selection UX #1292

syntrydy pushed a commit that referenced this issue Dec 11, 2018

@syntrydy syntrydy closed this Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment