New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store user pictures in FS #135

Open
yurem opened this Issue Oct 28, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@yurem
Contributor

yurem commented Oct 28, 2015

Currently we stores picture in LDAP as user attribute. We need to store them in FS.

We added API org.gluu.oxtrust.ldap.service.ImageRepository long time ago to work with images repository. We need to use it to store images in FS instead of storing it in LDAP.

Here is full plan:

  1. Review ImageRepository API. We added it 5 years ago. Maybe we need to improve something in it.
  2. Store in user entry path in the repo to image.
  3. Find all places in oxTrust (including SCIM too) where we remove users to remove image from repo too.

The parent issue is: #94

@yurem yurem added this to the Version 2.4.1 milestone Nov 18, 2015

@willow9886 willow9886 modified the milestones: Version 2.4.2, Version 2.4.1 Dec 7, 2015

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Dec 7, 2015

@yurem who should we assign this to?

@yurem

This comment has been minimized.

Contributor

yurem commented Jan 20, 2016

I think we should do next:

  1. Review org.gluu.oxtrust.ldap.service.ImageRepository to allow use it in oxAuth/oxTrust For example we can remove @create annotation from this class and inhereti it in oxAuth and oxTrust to allow initialize properly. Also we need to review it. Maybe we need to improve something in it.
  2. Update oxTrust to use this API to store images Some information in attribute + relative path of the image in repository.
  3. Review oxAuth to use these new picture attributes
  4. Review SCIM to work on similar to oxTrust way.
@yurem

This comment has been minimized.

Contributor

yurem commented Jan 20, 2016

Points 1-3 is one task. But point 4 we should do after finishing previous steps. It's independents step.
For 1-3 I offer to assign @qbert2k because he knows both oxAuth/oxTrust and knows how oxAuth should return picture claims.
For point 4 I offer to assign @shekhar16

@willow9886 willow9886 modified the milestones: Version 2.4.3, Version 2.4.2 Jan 29, 2016

@willow9886 willow9886 changed the title from Store user pictutes in FS to Store user pictures in FS Jan 29, 2016

@willow9886 willow9886 modified the milestones: Version 2.4.4, Version 2.4.3 Jan 29, 2016

@yurem yurem assigned yurem and unassigned shekhar16 Apr 22, 2016

@yurem yurem modified the milestones: CE 2.5.0, CE 2.4.4 Jul 14, 2016

@willow9886 willow9886 modified the milestones: CE 2.5.0, CE 3.0.0 Nov 1, 2016

@nynymike nynymike modified the milestones: CE 3.1.0, CE 3.0.0 Nov 29, 2016

@nynymike

This comment has been minimized.

Contributor

nynymike commented Nov 29, 2016

This feature is just not that critical. It can wait until 3.2

@nynymike

This comment has been minimized.

Contributor

nynymike commented Apr 8, 2017

Another caveat... oxTrust may not be user facing. Photos would have to be published somewhere public...

@nynymike nynymike modified the milestones: CE 3.2.0, CE 3.1.0 Apr 8, 2017

@yurem yurem removed this from the CE 3.2.0 milestone Oct 9, 2017

@yurem yurem added this to the CE 3.1.2 milestone Oct 9, 2017

@yurem

This comment has been minimized.

Contributor

yurem commented Oct 25, 2017

It's old issue. We need to review it from cluster perspective. Also it's not critical part because there is no requests to fix it. I offer to close it.

@yurem yurem modified the milestones: CE 3.1.2, CE 3.2.0 Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment