New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIM group patch anomaly when member list ends up empty #1372

Closed
jgomer2001 opened this Issue Nov 29, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@jgomer2001
Contributor

jgomer2001 commented Nov 29, 2018

Context of the problem here

@jgomer2001 jgomer2001 added the bug label Nov 29, 2018

@jgomer2001 jgomer2001 added this to the 3.1.5 milestone Nov 29, 2018

@jgomer2001 jgomer2001 self-assigned this Nov 29, 2018

jgomer2001 added a commit that referenced this issue Nov 29, 2018

jgomer2001 added a commit that referenced this issue Nov 29, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Nov 29, 2018

@jgomer2001 i have a problem with this fix.

else {
            group.setMembers(null);
        }

I'm afraid this can lead to NPE later.
If group.setMembers(); takes a list of members as parameter, better use an empty list instead of null.

@jgomer2001 jgomer2001 closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment