Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance how 2uf devices are displayed in user's profile #1484

Closed
jgomer2001 opened this issue Jan 23, 2019 · 4 comments

Comments

@jgomer2001
Copy link
Contributor

commented Jan 23, 2019

Currently we are showing something like

u2f

Can we fill some (or all) of the missing fields? Under fido branch at every user, there is all data needed. We can use oxId for "Id" column, displayName for "nickname", and creationDate for "date added". See oxDeviceRegistration ldap object class for more info.

If you want to go further you can use for modality "Super Gluu Device" or "Security key" if oxDeviceData is present or absent in the entry respectively.

@jgomer2001 jgomer2001 added this to the 3.1.6 milestone Jan 23, 2019

@syntrydy

This comment has been minimized.

Copy link
Collaborator

commented Jan 24, 2019

Fixed

@syntrydy

This comment has been minimized.

Copy link
Collaborator

commented Jan 24, 2019

image

@jgomer2001

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

Much better. Upon clicking on the Id of device, a modal window like this appear:
device detail

I'm not sure if we need to display pulic key and attestation cert, what do you think @yurem and @willow9886

The modal occupies a lot of space but it's not making effective use of it, maybe we can improve somehow.

@willow9886

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

I can't think of any reason an admin would need to see the public key here.. not sure about attestation cert. @jgomer2001 @yurem

@jgomer2001 jgomer2001 closed this Jan 30, 2019

shmorri added a commit to GluuFederation/docs-ce-prod that referenced this issue Mar 1, 2019

Updated 2FA screenshot
Updated with screenshot from [oxTrust issue 1484](GluuFederation/oxTrust#1484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.