New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requiredness for attributes in oxtrust's user form? #949

Closed
jgomer2001 opened this Issue Apr 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@jgomer2001
Contributor

jgomer2001 commented Apr 9, 2018

SCIM spec treats the following attributes as not required: displayName, name.givenName, and name.familyName.

Formerly in our server implementation we had those as required (<= 3.1.2). For 3.1.3 they were changed to optional to adhere more closely to standard. Citing nynymike:

I think WE SHOULD UPDATE our code to not require the attributes. oxTrust can generate GUIDs for any missing fields.

There was a related ticket some time ago as well.

This adjustment would affect first name, last name, and displayname fields of our oxTrust user form. @yurem can you assign this issue if there are no objections about this change?.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Aug 21, 2018

@jgomer2001 do you mean first name, last name and displayname is not mandatory?

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Aug 21, 2018

I thought it over and concluded we'd better not change anything. For instance, our UI form has email and password required, while in SCIM you can create passwordless users or not providing emails at all. And it doesn't make sense to relax those two attributes in oxtrust!

@jgomer2001 jgomer2001 closed this Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment