Conversation
Closes #22 Adds an `extra-test-os` input to the reusable Rust workflow: a JSON array of additional runner images (default `[]`). A matrixed `Test (<os>)` job mirrors the existing `Test` job on each image and is skipped entirely when the array is empty. The existing `Test` job is untouched, so its check name — required by branch rulesets in consumer repos — does not change, and current callers see no difference. First consumer: Glyndor/podup#43 (macOS support) will pass `extra-test-os: '["macos-latest"]'`. ## Test plan - Default callers: `extra-test-os` defaults to `[]` → `test-extra` skipped (job-level `if`) - podup's branch will exercise the populated path once the pin is bumped Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
added
effort:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes develop to main:
extra-test-osinput on the reusable Rust workflow (Closes ci: let rust-ci run the test job on extra runner images #22 follow-through; consumer repos pin to the resulting main SHA)No behavior change for existing callers: the input defaults to
[]and the newTest (<os>)job is skipped when empty.