Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines containing a URL ignored due to // #45

Closed
Moesh-zz opened this issue Aug 2, 2016 · 1 comment
Closed

Lines containing a URL ignored due to // #45

Moesh-zz opened this issue Aug 2, 2016 · 1 comment

Comments

@Moesh-zz
Copy link

@Moesh-zz Moesh-zz commented Aug 2, 2016

Comments should be differentiated from URLs, but also tracked if used in JSON or NBT data.

@GnaspGames
Copy link
Owner

@GnaspGames GnaspGames commented Aug 3, 2016

Okay, so this is a fiddly one.

The issue is // found withing a string.
A string is anything found withing double quotes. Example:

"value": { "translate": "Ideal Development Environment\nby Moesh (http://moesh.ca)"}

My solution is going to be to match strings that contain // and ignore them, while still removing other comments.

GnaspGames added a commit that referenced this issue Aug 3, 2016
Fixes #45
Fixes #46
@GnaspGames GnaspGames closed this in ba56c3f Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.