New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startModuleZ has no effect on Z coordinate starting position #82

Closed
bananenbroek4 opened this Issue Jan 17, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@bananenbroek4

bananenbroek4 commented Jan 17, 2017

Increasing "moduleStartZ": 0 to "moduleStartZ": 1 will raise the module by one in the y-axis when expected behaviour would be movement on the z-axis

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Jan 17, 2017

Owner

Thanks for the bug report.

I'll have a look into it.

Owner

GnaspGames commented Jan 17, 2017

Thanks for the bug report.

I'll have a look into it.

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Jan 17, 2017

Owner

Yup, looks like a type here:

startX, startZ, startY, stopX, stopY, stopZ, border

The parameters startX, startZ, startY are being passed through in the wrong order.

I'll submit a fix and release a new pre-release. I'm not in a position to test the fix at the moment, would you be able to let me know if it works?

If so, I think it's about time that I finish the pre-release cycle and release 1.1.0 properly.

Thanks!

Owner

GnaspGames commented Jan 17, 2017

Yup, looks like a type here:

startX, startZ, startY, stopX, stopY, stopZ, border

The parameters startX, startZ, startY are being passed through in the wrong order.

I'll submit a fix and release a new pre-release. I'm not in a position to test the fix at the moment, would you be able to let me know if it works?

If so, I think it's about time that I finish the pre-release cycle and release 1.1.0 properly.

Thanks!

GnaspGames added a commit that referenced this issue Jan 17, 2017

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Jan 17, 2017

Owner

1.1.0-pre9 has now been released. Let me know how you get on?

Owner

GnaspGames commented Jan 17, 2017

1.1.0-pre9 has now been released. Let me know how you get on?

@bananenbroek4

This comment has been minimized.

Show comment
Hide comment
@bananenbroek4

bananenbroek4 Jan 17, 2017

bananenbroek4 commented Jan 17, 2017

@bananenbroek4 bananenbroek4 changed the title from Changing "moduleStartZ" influences starting Y position rather than "moduleStartY", which does nothing to startModuleZ has no effect on Z coordinate starting position Jan 21, 2017

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Feb 14, 2017

Owner

bananenbroek4 - 01/21/2017
I don't think moduleStartZ works still
Y works now though

Owner

GnaspGames commented Feb 14, 2017

bananenbroek4 - 01/21/2017
I don't think moduleStartZ works still
Y works now though

GnaspGames added a commit that referenced this issue Feb 14, 2017

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Feb 14, 2017

Owner

@bananenbroek4 Sorry it's taken a while; but this should now be fixed in 1.1.0-pre10.

Owner

GnaspGames commented Feb 14, 2017

@bananenbroek4 Sorry it's taken a while; but this should now be fixed in 1.1.0-pre10.

@GnaspGames GnaspGames closed this Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment