New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands should be created in the order that they are entered #91

Closed
GnaspGames opened this Issue Apr 14, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@GnaspGames
Owner

GnaspGames commented Apr 14, 2017

So, for some reason I created Smelt to build the output command blocks in the reverse order to how they are entered into the MCC file.

This was intentional, but for reasons that turned out to be... wrong! Let's just say that.

So, I will update Smelt to change this. This will be breaking change, because if anyone has implemented 'startup' auto impulse commands that need to be run in a specific order, they may have had to reverse them in their MCC files.

Because this is a breaking change, I will implement the change using a config entry. The default behaviour will be the existing one, and then in the next major release the proper order will become the default behaviour.

The config setting will be Commands.CreateInOrderProvided which will be a boolean.

@GnaspGames GnaspGames self-assigned this Apr 14, 2017

GnaspGames added a commit that referenced this issue Apr 14, 2017

Issue #91 Add 'CreateInOrderProvided' and...
implement the corrected behaviour when CreateInOrderProvided is true.
@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Apr 16, 2017

Owner

This was fixed in version 1.1.1

Owner

GnaspGames commented Apr 16, 2017

This was fixed in version 1.1.1

@GnaspGames GnaspGames closed this Apr 16, 2017

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Apr 27, 2017

Owner

I have to re-open this.

Well, it appears that I was right. There was a very good reason the command blocks are created in reverse order.

Impulse-Chains don't work when command blocks are created in the order in which they are written.

The impulse command at the start of the chain runs BEFORE the chains exist.

Owner

GnaspGames commented Apr 27, 2017

I have to re-open this.

Well, it appears that I was right. There was a very good reason the command blocks are created in reverse order.

Impulse-Chains don't work when command blocks are created in the order in which they are written.

The impulse command at the start of the chain runs BEFORE the chains exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment