New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added included plugin named delay #95

Merged
merged 3 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@mrjvs
Contributor

mrjvs commented Apr 26, 2017

beware: this uses markerTag fix and setJSON to work!!

@GnaspGames

This comment has been minimized.

Show comment
Hide comment
@GnaspGames

GnaspGames Apr 26, 2017

Owner

The support module you've added is very simular to what I already have in the Smelt support modules (plus there are different versions for MC 1.9/1.10.

See: https://github.com/GnaspGames/Smelt/blob/master/BangCommands/Included/smelt-for-1.11.mcc
And: https://github.com/GnaspGames/Smelt/blob/master/BangCommands/Included/smelt-for-1.9.mcc

The only difference, you have a kill command at the end. Why is that?

/kill @e[tag=comDelayDone]

Doesn't the entity die in the next tick anyway?

Owner

GnaspGames commented Apr 26, 2017

The support module you've added is very simular to what I already have in the Smelt support modules (plus there are different versions for MC 1.9/1.10.

See: https://github.com/GnaspGames/Smelt/blob/master/BangCommands/Included/smelt-for-1.11.mcc
And: https://github.com/GnaspGames/Smelt/blob/master/BangCommands/Included/smelt-for-1.9.mcc

The only difference, you have a kill command at the end. Why is that?

/kill @e[tag=comDelayDone]

Doesn't the entity die in the next tick anyway?

@mrjvs

This comment has been minimized.

Show comment
Hide comment
@mrjvs

mrjvs Apr 26, 2017

Contributor

You are absolutely right. I am not at my best the last few days. I shall commit some things to make them work with your support modules.

Contributor

mrjvs commented Apr 26, 2017

You are absolutely right. I am not at my best the last few days. I shall commit some things to make them work with your support modules.

GnaspGames added a commit that referenced this pull request Apr 27, 2017

For #95 - improved delay.js formating and comments
* Also supports 1.9/1.10
* Also, fixed issue with support modules not correct.

@GnaspGames GnaspGames merged commit 551ae66 into GnaspGames:master Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment