#94 the fix for markerTags not showing up on plugin created commandBlocks #97
Conversation
|
This is the implementation for #94 Honestly I'm a little unsure whether marker entities should be created inside plugins. I can see someone setting it without realising that it will create many more than intended if they use a bang command before resetting it. But I'm happy to let this go and see what happens. |
mrjvs
changed the title
mrjvs
changed the title
|
@GnaspGames To fix the more than intended in the delay plugin I used the setJSON function that is also suggested in a pullrequest. |
|
Right, I see now! Your setting the markerTag INSIDE the band command, and needed it to revert back to whatever was before the bang command was called. Actually that's what happens with the other JSON props like https://github.com/GnaspGames/Smelt/blob/master/BangCommands/Helper.js#L21 This stops JSON properties from persisting for more than one command when used in a band command. I think I would prefer the markerTag to behave the same so that it's consistent. I've already started adding to this on my local version, so I'll look into it. There won't be a need for |
|
Great, but not a single markertag is created on plugin created command block even when the markertag is declared before the the bang command. |
|
Yes, that will be implemented too. I've got this. 👍 |
Also, should add to commands.push() not the module.
bang commands in the same way other json options are. Any markerTag assigned inside a band command WON'T persist outside of it. But any markerTag entity assigned before the bang command is called will, so long as it's not reset inside the band command script.
No description provided.