Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Gnosis DutchX Buyback #4
left a comment
Hi @samparsky , thanks for submitting the bounty.
Yesterday I was overlooking the code, and I think it's a good start. The thing is that I would appreciate if you can document a bit the approach you are taking, because I frankly I had a bit difficulty yesterday understanding.
I'm interested in how you model the problem.
On this review, I just added some small comments on some things not related to the logic of the contract. After adding the documentation, I will do a second review of the logic itself.
Thanks for the submission. If you have any questions let me know.
left a comment
Happy new year @samparsky!,
First of all, sorry for the delay, Christmas is a busy season with lots of people on vacations.
Please, note that
I receive the notifications on both gitter and Github. With the ones in Github I have enough, next time, please let's just use only Github. There's no need to SPAM other users.
Thanks too for adding documentation, it made the review MUCH simpler.
Anyway, I'm afraid I have some concerns regarding this contract. They were added as comments.
As a summary of the most important ones:
5. The tip is not enforced. Even if you say that you give a tip for poking the contract, you can skip the part of adding ether as a tip.
@anxolin Thanks for the review. I have gone through the code and made a number of changes to the logic. The
Also added a function
I have added error messages to
The test cases have been fixed and is working okay now.
Please let me know when you will be available