[gnc-date.cpp] gnc_g_date_new_today calls gnc_gdate_set_today

instead of vice-versa.

- avoids malloc/free in gnc_gdate_set_today
- avoids unnecessary dmy->julian->dmy(*) conversion

(*) the GDate is typically used by gdate_to_time64 which performs a
julian->dmy conversion, and this is now avoided

Author: christopherlam

libgnucash/engine/gnc-date.cpp

@@ -1230,20 +1230,17 @@ GDate time64_to_gdate (time64 t)
 
 GDate* gnc_g_date_new_today ()
 {
-    GncDate gncd;
-    auto ymd = gncd.year_month_day();
-    auto month = static_cast<GDateMonth>(ymd.month);
-    auto result = g_date_new_dmy (ymd.day, month, ymd.year);
-    g_assert(g_date_valid (result));
-    return result;
+    GDate* rv = g_date_new ();
+    gnc_gdate_set_today (rv);
+    return rv;
 }
 
 void
 gnc_gdate_set_today (GDate* gd)
 {
-    GDate *today = gnc_g_date_new_today ();
-    g_date_set_julian (gd, g_date_get_julian (today));
-    g_date_free (today);
+    g_return_if_fail (gd != nullptr);
+    auto ymd = GncDate().year_month_day();
+    g_date_set_dmy (gd, ymd.day, static_cast<GDateMonth>(ymd.month), ymd.year);
 }
 
 void