From 44cd4c1af1a0027cc166bafcb60fc763c5b16390 Mon Sep 17 00:00:00 2001 From: Richard Cohen Date: Mon, 6 Mar 2023 10:48:26 +0000 Subject: [PATCH 1/3] Remove unused ${REGISTER_CXXFLAG} --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f997cea582f..5be58194058 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -593,7 +593,7 @@ if (UNIX) set( CMAKE_C_FLAGS "-Werror -Wno-pointer-sign -Wall -Wmissing-prototypes -Wmissing-declarations ${CMAKE_C_FLAGS}") set( CMAKE_C_FLAGS "-Wno-error=deprecated-declarations -Wno-error=parentheses ${CMAKE_C_FLAGS}") set( CMAKE_CXX_FLAGS "-Werror -Wall -Wmissing-declarations -Wno-error=parentheses ${CMAKE_CXX_FLAGS}") - set( CMAKE_CXX_FLAGS "-Wno-error=deprecated-declarations ${REGISTER_CXXFLAG} ${CMAKE_CXX_FLAGS}") + set( CMAKE_CXX_FLAGS "-Wno-error=deprecated-declarations ${CMAKE_CXX_FLAGS}") set( CMAKE_C_FLAGS_RELEASE "-O3 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ${CMAKE_C_FLAGS}") endif() if (MINGW) From 0f0b5e3fe7fd90c5deb9b6fcc41e0cb80be478a6 Mon Sep 17 00:00:00 2001 From: Richard Cohen Date: Mon, 6 Mar 2023 10:48:50 +0000 Subject: [PATCH 2/3] Remove -Wno-error=parentheses It was added for gcc 8.0 and gtk 3.14 --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5be58194058..222825f28c4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -591,8 +591,8 @@ set(CMAKE_C_EXTENSIONS ON) if (UNIX) set( CMAKE_C_FLAGS "-Werror -Wno-pointer-sign -Wall -Wmissing-prototypes -Wmissing-declarations ${CMAKE_C_FLAGS}") - set( CMAKE_C_FLAGS "-Wno-error=deprecated-declarations -Wno-error=parentheses ${CMAKE_C_FLAGS}") - set( CMAKE_CXX_FLAGS "-Werror -Wall -Wmissing-declarations -Wno-error=parentheses ${CMAKE_CXX_FLAGS}") + set( CMAKE_C_FLAGS "-Wno-error=deprecated-declarations ${CMAKE_C_FLAGS}") + set( CMAKE_CXX_FLAGS "-Werror -Wall -Wmissing-declarations ${CMAKE_CXX_FLAGS}") set( CMAKE_CXX_FLAGS "-Wno-error=deprecated-declarations ${CMAKE_CXX_FLAGS}") set( CMAKE_C_FLAGS_RELEASE "-O3 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ${CMAKE_C_FLAGS}") endif() From d87ee73048ce0ed48bdb8fbddfa0cee88ac0998a Mon Sep 17 00:00:00 2001 From: Richard Cohen Date: Thu, 2 Mar 2023 13:41:02 +0000 Subject: [PATCH 3/3] Remove -Wno-pointer-sign Add the necessary casts in gnc-gwen-guic.c --- CMakeLists.txt | 4 ++-- gnucash/import-export/aqb/gnc-gwen-gui.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 222825f28c4..b1104a2a475 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -590,14 +590,14 @@ set(CMAKE_C_STANDARD_REQUIRED ON) set(CMAKE_C_EXTENSIONS ON) if (UNIX) - set( CMAKE_C_FLAGS "-Werror -Wno-pointer-sign -Wall -Wmissing-prototypes -Wmissing-declarations ${CMAKE_C_FLAGS}") + set( CMAKE_C_FLAGS "-Werror -Wall -Wmissing-prototypes -Wmissing-declarations ${CMAKE_C_FLAGS}") set( CMAKE_C_FLAGS "-Wno-error=deprecated-declarations ${CMAKE_C_FLAGS}") set( CMAKE_CXX_FLAGS "-Werror -Wall -Wmissing-declarations ${CMAKE_CXX_FLAGS}") set( CMAKE_CXX_FLAGS "-Wno-error=deprecated-declarations ${CMAKE_CXX_FLAGS}") set( CMAKE_C_FLAGS_RELEASE "-O3 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ${CMAKE_C_FLAGS}") endif() if (MINGW) - set( CMAKE_C_FLAGS "-Werror -Wno-pointer-sign -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-error=deprecated-declarations ${CMAKE_C_FLAGS}") + set( CMAKE_C_FLAGS "-Werror -Wall -Wmissing-prototypes -Wmissing-declarations -Wno-error=deprecated-declarations ${CMAKE_C_FLAGS}") set( CMAKE_CXX_FLAGS "-DWINVER=0x0500 -D_EMULATE_GLIBC=0 ${CMAKE_CXX_FLAGS}") # Workaround for bug in gtest on mingw, see https://github.com/google/googletest/issues/893 and https://github.com/google/googletest/issues/920 endif() diff --git a/gnucash/import-export/aqb/gnc-gwen-gui.c b/gnucash/import-export/aqb/gnc-gwen-gui.c index a39be8870b4..44a492e82c1 100644 --- a/gnucash/import-export/aqb/gnc-gwen-gui.c +++ b/gnucash/import-export/aqb/gnc-gwen-gui.c @@ -1575,8 +1575,8 @@ checkcert_cb(GWEN_GUI *gwen_gui, const GWEN_SSLCERTDESCR *cert, hash = GWEN_SslCertDescr_GetFingerPrint(cert); status = GWEN_SslCertDescr_GetStatusText(cert); - g_checksum_update (gcheck, hash, strlen (hash)); - g_checksum_update (gcheck, status, strlen (status)); + g_checksum_update (gcheck, (const guchar *)hash, strlen (hash)); + g_checksum_update (gcheck, (const guchar *)status, strlen (status)); /* Did we get the permanently accepted certs from AqBanking? */ if (gui->permanently_accepted_certs) @@ -1597,7 +1597,7 @@ checkcert_cb(GWEN_GUI *gwen_gui, const GWEN_SSLCERTDESCR *cert, g_warning("Can't check permanently accepted certs from invalid AqBanking cert store."); } - g_checksum_get_digest (gcheck, cert_hash, &hashlen); + g_checksum_get_digest (gcheck, (guint8 *)cert_hash, &hashlen); g_checksum_free (gcheck); g_assert (hashlen <= sizeof (cert_hash));