Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment of Account Hierarchy Templates. #300

Closed
wants to merge 1 commit into from

Conversation

@DiMan
Copy link
Contributor

commented Mar 5, 2018

Adjustment of Account Hierarchy Templates.
(mentioned in PR #293 on GitHub)

  1. Added namespace section (header)
  2. Added missing placeholder

After adjustment, I checked it with xmllint => no errors.
for i in *-xea; do xmllint --noout $i; done

Two questions:

  • I use two versions of GnuCash: de and ru. I have seen that in the German version the most files haven't definition of namespace section. Should I adjust the "de"-templates? How about "C"-templates?
  • There are three comments at the end of each hierarchy template file. Do they have any meaning? Can they be removed?
    < !-- Local variables: -->
    < !-- mode: xml -->
    < !-- End: -->
Di Mang
Adjustment of Account Hierarchy Templates.
(mentioned in PR #293 on GitHub)

1) Added namespace section (header)
2) Added missing placeholder
code-gnucash-org pushed a commit that referenced this pull request Mar 6, 2018
@fellen

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

Good questions!

Your template looks well.

@fellen fellen closed this Mar 6, 2018

@DiMan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2018

@jralls

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

Yes, the comments at the end are to help emacs recognize that the files are xml since they don't have 'xml' as an extension. IMO it makes more sense for an emacs user who frequently edits these files (a population that I believe numbers around 0 because nobody edits these files frequently) to just add 'gnucash-xea' to the auto-mode-alist for their preferred xml mode. Occasional editors can just m-x xml-mode when they open the file.

That's a long way of saying that removing the comments is OK.

@jralls

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

If an xml file uses namespaces it must declare them. Without the declaration it is not well-formed xml. The fact that our current parser is broken--the xml spec says that parsers should abort immediately if they encounter ill-formed xml--is immaterial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.