From 0dd14161277ed4482715f7b310ce6bda1ee8e67d Mon Sep 17 00:00:00 2001 From: Jon Langevin Date: Fri, 24 Apr 2026 22:54:24 -0400 Subject: [PATCH] fix(requesting-code-review): correct fixture line refs (post-merge Copilot finding) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hunk @@ -10,6 +10,12 @@ places the Create function declaration at line 10 (shown as @@ context label), so content starts at line 11: line 11: return d.client.Send("create", ...) line 12: "kind": d.kind ← Create's kind ref (was 11) ... line 18: func Inspect(...) ← Inspect location (was 17) ... line 27: "kind": d.kind ← Delete's kind ref (was 26) Fixes three stale refs in expected-new-result.md: bug-class scan citation (line 10), Finding 1 Location (line 30), and Finding 1 What's wrong (line 31). Co-Authored-By: Claude Sonnet 4.6 --- .../test-fixtures/sibling-asymmetry/expected-new-result.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/skills/requesting-code-review/test-fixtures/sibling-asymmetry/expected-new-result.md b/skills/requesting-code-review/test-fixtures/sibling-asymmetry/expected-new-result.md index 81f2038..13a17ae 100644 --- a/skills/requesting-code-review/test-fixtures/sibling-asymmetry/expected-new-result.md +++ b/skills/requesting-code-review/test-fixtures/sibling-asymmetry/expected-new-result.md @@ -7,7 +7,7 @@ No MISSING items. No SCOPE CREEP. ## Bug-class scan -**Symmetry violations** — FINDING. `Inspect` omits `"kind": d.kind`. Both `Create` (line 11) and `Delete` (line 26) set it as the first arg in their maps. (See Finding 1 below.) +**Symmetry violations** — FINDING. `Inspect` omits `"kind": d.kind`. Both `Create` (line 12) and `Delete` (line 27) set it as the first arg in their maps. (See Finding 1 below.) **Checks completed without further findings:** @@ -27,8 +27,8 @@ No MISSING items. No SCOPE CREEP. ### Finding 1 — Inspect omits `kind` arg present in all sibling methods - **Severity**: Important - **Bug class**: Symmetry violations -- **Location**: `lib/dispatcher.go:17` -- **What's wrong**: The new `Inspect` method's args map omits `"kind": d.kind`. Sibling methods `Create` (line 11) and `Delete` (line 26) both set it as the first key. +- **Location**: `lib/dispatcher.go:18` +- **What's wrong**: The new `Inspect` method's args map omits `"kind": d.kind`. Sibling methods `Create` (line 12) and `Delete` (line 27) both set it as the first key. - **Why it matters**: Receivers downstream rely on `kind` to dispatch correctly. Calling `Inspect` will silently target the wrong dispatch path or return `not found` because the receiver cannot disambiguate the request type. - **Suggested fix**: Add `"kind": d.kind,` as the first key in the args map, matching siblings.