feat: add product capture compute step#3
Merged
Conversation
b6f21b9 to
b7d3503
Compare
There was a problem hiding this comment.
Pull request overview
Adds a first-class compute step for workflow-compute’s typed product-capture workload, updates the plugin manifest/docs accordingly, and exposes proof result_preview fields to downstream consumers.
Changes:
- Introduces
step.compute_product_captureto submit a typed product-capture URL workload and wait for an accepted proof. - Extends proof output handling to include
result_previewand (additionally) flatten preview fields into the step output. - Updates plugin manifest/docs/tests and bumps
workflow-computedependency to include result-preview support.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SPEC.md | Documents the new product-capture step and manifest/runtime step type drift prevention. |
| README.md | Adds user-facing guidance for using step.compute_product_capture. |
| plugin.json | Registers step.compute_product_capture in manifest stepTypes. |
| internal/steps.go | Implements product-capture step, adds state-field URL resolution, and exposes result_preview in outputs. |
| internal/steps_test.go | Adds manifest-vs-runtime stepTypes assertion and product-capture step tests. |
| internal/plugin.go | Registers the new step type and wiring in CreateStep. |
| go.mod | Updates Go/workflow-compute version metadata. |
| go.sum | Updates sums for the workflow-compute bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b7d3503 to
e7b260c
Compare
intel352
commented
May 21, 2026
intel352
left a comment
Contributor
Author
There was a problem hiding this comment.
Addressed Copilot review: result previews now flatten only an explicit ProductSnapshot allowlist, so reserved/control keys like error are kept inside result_preview only. Step type tests now compare the full expected slice, including step.compute_wait.
e7b260c to
8417c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
step.compute_product_capturefor typed workflow-compute product-capture workloadsresult_previewfields into step output for ProductSnapshot consumersVerification
GOWORK=off go test ./...GOWORK=off wfctl validate workflow.yamlDepends on workflow-compute PR #112, merged at dc0b7c8.