Skip to content

feat: add product capture compute step#3

Merged
intel352 merged 1 commit into
mainfrom
feat/product-capture-preview
May 21, 2026
Merged

feat: add product capture compute step#3
intel352 merged 1 commit into
mainfrom
feat/product-capture-preview

Conversation

@intel352

Copy link
Copy Markdown
Contributor

Summary

  • add step.compute_product_capture for typed workflow-compute product-capture workloads
  • flatten accepted proof result_preview fields into step output for ProductSnapshot consumers
  • update manifest/docs/spec and bump workflow-compute to the merged result-preview support

Verification

  • GOWORK=off go test ./...
  • GOWORK=off wfctl validate workflow.yaml

Depends on workflow-compute PR #112, merged at dc0b7c8.

Copilot AI review requested due to automatic review settings May 21, 2026 00:35
@intel352 intel352 force-pushed the feat/product-capture-preview branch from b6f21b9 to b7d3503 Compare May 21, 2026 00:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a first-class compute step for workflow-compute’s typed product-capture workload, updates the plugin manifest/docs accordingly, and exposes proof result_preview fields to downstream consumers.

Changes:

  • Introduces step.compute_product_capture to submit a typed product-capture URL workload and wait for an accepted proof.
  • Extends proof output handling to include result_preview and (additionally) flatten preview fields into the step output.
  • Updates plugin manifest/docs/tests and bumps workflow-compute dependency to include result-preview support.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
SPEC.md Documents the new product-capture step and manifest/runtime step type drift prevention.
README.md Adds user-facing guidance for using step.compute_product_capture.
plugin.json Registers step.compute_product_capture in manifest stepTypes.
internal/steps.go Implements product-capture step, adds state-field URL resolution, and exposes result_preview in outputs.
internal/steps_test.go Adds manifest-vs-runtime stepTypes assertion and product-capture step tests.
internal/plugin.go Registers the new step type and wiring in CreateStep.
go.mod Updates Go/workflow-compute version metadata.
go.sum Updates sums for the workflow-compute bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/steps.go
Comment thread internal/steps_test.go Outdated
@intel352 intel352 force-pushed the feat/product-capture-preview branch from b7d3503 to e7b260c Compare May 21, 2026 00:39

@intel352 intel352 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed Copilot review: result previews now flatten only an explicit ProductSnapshot allowlist, so reserved/control keys like error are kept inside result_preview only. Step type tests now compare the full expected slice, including step.compute_wait.

@intel352 intel352 force-pushed the feat/product-capture-preview branch from e7b260c to 8417c63 Compare May 21, 2026 00:44
@intel352 intel352 merged commit 7d36b9e into main May 21, 2026
4 checks passed
@intel352 intel352 deleted the feat/product-capture-preview branch May 21, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants