refactor: ♻️ Move main mod API funcs to ModLoaderMod, from ModLoader
#208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no changes to the mod funcs, aside from making them static
ithinkandicode
added
refactor / cleanup
ithinkandicode
changed the title
ModLoaderMod, from ModLoaderModLoaderMod, from ModLoader
28 tasks
Qubus0
reviewed
Apr 2, 2023
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
No big complaints, looks pretty good
KANAjetzt
approved these changes
Apr 4, 2023
Member
KANAjetzt
left a comment
KANAjetzt
left a comment
There was a problem hiding this comment.
Nice - ty darkly.
Tested it by running brotato with my mods.
Member
|
Fancy fixing the conflicts and merging this @ithinkandicode? |
This function did not exist on the main branch until now, so we don't need to depreciate it.
Member
|
Tested again with Brotato and 9 aktive Mods |
ithinkandicode
changed the title
ModLoaderMod, from ModLoaderModLoaderMod, from ModLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the main funcs from
ModLoader.methodtoModLoaderMod.method, as discussed in #153.Some vars had to be moved from
ModLoadertoModLoaderStore:is_initializingandscript_extensions.Includes deprecated funcs in the main ModLoader file. Developed alongside #207 (which downgrades the inevitable flood of fatal errors to just warnings).
Related: