Skip to content

refactor: 🚚 Moved and renamed ModLoaderSteam #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2023
Merged

refactor: 🚚 Moved and renamed ModLoaderSteam #230

merged 3 commits into from
Apr 23, 2023

Conversation

@KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Apr 21, 2023 •
edited
Loading

ModLoaderSteam is only used internally by the ModLoader

  • ModLoaderSteam renamed to _ModLoaderSteam
  • Moved from /api/third_party/steam.gd to /internal/third_party/steam.gd

works towards #153

@KANAjetzt KANAjetzt added the refactor / cleanup Improves readability or maintainability label Apr 21, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Apr 21, 2023
@KANAjetzt KANAjetzt requested review from a team, Qubus0 and ithinkandicode April 21, 2023 22:11
@KANAjetzt KANAjetzt self-assigned this Apr 21, 2023
Qubus0
Qubus0 reviewed Apr 22, 2023
View reviewed changes
@KANAjetzt KANAjetzt added this pull request to the merge queue Apr 23, 2023
Merged via the queue into GodotModding:development with commit 5fc7268 Apr 23, 2023
@KANAjetzt KANAjetzt deleted the refactor_steam_gd branch April 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

@ithinkandicode ithinkandicode Awaiting requested review from ithinkandicode

Assignees

@KANAjetzt KANAjetzt

Labels

refactor / cleanup Improves readability or maintainability

Projects

None yet

Milestone

3.x - v6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@KANAjetzt @Qubus0