New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile cleanup #23

Merged
merged 133 commits into from Jan 23, 2017

Conversation

Projects
None yet
3 participants
@henryiii
Copy link
Member

henryiii commented Dec 19, 2016

This is the "dev" branch that has had several examples added. I've merged it with the latest changes in master, and cleaned up the make file system. This includes all three cleanups planned. See #22.

Main features:

  • New/updated examples
  • Huge, massive cleanup to code, source organization, and build procedures
  • Powerful new CMake system
  • GooFit Packages: build your own code and PDFs without forking GooFit
  • Separable compilation (optional)
  • Script to run all examples with times
  • Auto compute compatibility discovery, extra options depending on compute setting

CMake is highly recommended, and should be much better than the old make builds. Those may go away at some point after this is merged.

Please build with both OMP and CUDA, and review!

hassec added some commits Mar 17, 2016

added a minimal example. Comparison between MINT and GooFit for D->K*…
…rho->K3Pi where K* and rho are in an s-wave. As one can easily see there still seems to be a problem though.. Spinfactors and lineshapes have been checked and are the same as in MINT.
forgot to change the normalization durin last design change, but it s…
…eems like there is still an error somewhere..
Added some comments to explain the rough outline of the functions, no…
…rmalisation is not crashing anymore,not complety sure about results though
changed the example to include S,P and D wave, differences in distrib…
…utions are unchanged.. Cause still unclear!!.
the cause of the differences in the distributions was a mistake in ho…
…w the pions were switched. So a user mistake, no bug in the evaluation
Using git-subrepo instead of submodule, because it's easier for users.
git subrepo clone --branch=GooFit https://github.com/hassec/MCBooster.git

subrepo:
  subdir:   "MCBooster"
  merged:   "685a1db"
upstream:
  origin:   "https://github.com/hassec/MCBooster.git"
  branch:   "GooFit"
  commit:   "685a1db"
git-subrepo:
  version:  "0.3.0"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cb2995b"
DP4Pdf now includes a function GenerateSig to generate signal events …
…corresponding to the created model.

This is can later be used to add this functionality more generally to other pdf.
EvalVar.h holds the struct to calculate the 5 variables m12, m34, cos12, cos34, and phi from the four vectors.
Added new example to show usage of GenerateSig.

@henryiii henryiii changed the title WIP: Makefile cleanup Makefile cleanup Jan 13, 2017

@hassec

hassec approved these changes Jan 20, 2017

Copy link
Member

hassec left a comment

As discussed in the meeting, I have used this branch already and did not come across any problems, therefore I believe we can go ahead and merge this unless anybody thinks differently.

@henryiii henryiii merged commit d90354c into master Jan 23, 2017

@henryiii henryiii modified the milestone: V 2.0 Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment