New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI support #51

Merged
merged 39 commits into from Mar 30, 2017

Conversation

Projects
None yet
2 participants
@henryiii
Copy link
Member

henryiii commented Mar 20, 2017

This is the new MPI support for GooFit.

galapaegos and others added some commits Jan 9, 2017

Added ThrustOverride, which controls granularity of kernel's.
Added policy's to GooPdf.
Added python script to find optimal group/grain size for a given problem.
Adding Makefile.common back in, will be removed in a future version
Added CUDA override for group/grain size
Fixed code to use THRUST_DEVICE methods for checking CUDA vs OMP versions

henryiii added some commits Mar 20, 2017

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 24, 2017

Codecov Report

Merging #51 into master will decrease coverage by 0.07%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage    33.8%   33.73%   -0.08%     
==========================================
  Files          25       25              
  Lines        6552     6572      +20     
  Branches     1260     1261       +1     
==========================================
+ Hits         2215     2217       +2     
- Misses       4337     4355      +18
Impacted Files Coverage Δ
include/goofit/PdfBase.h 70.58% <ø> (ø) ⬆️
include/goofit/PDFs/GooPdf.h 40% <ø> (ø) ⬆️
src/goofit/PdfBase.cc 29.91% <0%> (-1.06%) ⬇️
src/PDFs/GooPdf.cu 49.5% <100%> (+0.16%) ⬆️
include/goofit/Variable.h 75% <50%> (ø) ⬆️
src/PDFs/PdfBase.cu 59.31% <50%> (-0.14%) ⬇️
src/goofit/Variable.cc 33.33% <7.69%> (-21.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c36440...96c4b05. Read the comment docs.

henryiii added some commits Mar 28, 2017

Fixes for MPI, incorrect cuda card selection fixed, better output, re…
…moved segfault if PBS env var is missing
Merge branch 'master' into mpi
Conflicts:
	README.md
	include/goofit/Application.h

@henryiii henryiii changed the title [WIP] MPI support MPI support Mar 29, 2017

@henryiii

This comment has been minimized.

Copy link
Member

henryiii commented Mar 29, 2017

I think this is pretty close to being ready to merge. @galapaegos, please verify things still work on your end. The change I've made were:

  • Application help on parse failure only prints on one MPI thread
  • Fix segfault if PBS env variable is missing
  • GPU card was probably being reselected as 0, fixed
  • CountingVariable is now required at the API level for main PDFs, used in more examples
  • Reformatted to match rest of GooFit with astyle

Using toy 0 1 still gives odd warnings, but this happens with or without MPI.

@henryiii henryiii requested a review from galapaegos Mar 29, 2017

henryiii added some commits Mar 29, 2017

@galapaegos galapaegos added bug and removed bug labels Mar 30, 2017

@galapaegos
Copy link
Contributor

galapaegos left a comment

Changes function well, no issues to report.

@henryiii henryiii merged commit d210ed5 into master Mar 30, 2017

2 of 4 checks passed

codecov/patch 30.76% of diff hit (target 33.8%)
Details
codecov/project 33.73% (-0.08%) compared to 3c36440
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@henryiii henryiii deleted the mpi branch Apr 1, 2017

@henryiii henryiii modified the milestone: V 2.0 Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment