Fix raw and modern input#318
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Raw/Modern mouse input handling by moving raw-delta consumption into a dedicated function and ensuring freelook camera input is applied through the correct control path.
Changes:
- Replace
mouse_get_camera()withconsume_raw_mouse_deltas()and update the camera entity-control injection to consume accumulated raw deltas there. - Add a freelook-specific path that consumes and applies deltas during
mouse_get_delta_hook, since freelook bypasses the normal entity control path. - Update the mouse input header API to expose the new consumption function.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
game_patch/misc/camera.cpp |
Consumes accumulated raw mouse deltas in the entity control injection point via consume_raw_mouse_deltas(). |
game_patch/input/mouse.h |
Updates the public mouse-input API by replacing mouse_get_camera() with consume_raw_mouse_deltas(). |
game_patch/input/mouse.cpp |
Implements consume_raw_mouse_deltas() and adds freelook flushing from mouse_get_delta_hook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.