Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

audit_customer_subscription fails when subscription == null #22

Open
markstahler opened this Issue · 4 comments

2 participants

@markstahler

Auditing a customer subscription for a newly created customer object fails when subscription data has not been created. It looks like Customer.subscription is null on creation and if this isnt updated before audit_customer_subscription it fails because subscription doesnt have a status.

*** AttributeError: 'NoneType' object has no attribute 'status'

@markstahler

How is this? I can send a pull request.

if (hasattr(customer, 'suspended') and customer.suspended):
    result = AUDIT_RESULTS['suspended']
else:
    try:
        result = AUDIT_RESULTS[customer.subscription.status]
    except AttributeError, err:
        result = AUDIT_RESULTS['no_subscription']
return result
@leetrout
Owner

I think changing L17 to if hasattr(customer, 'subscription') and customer.subscription is not None: would be more concise in this case since there is already exception handling in place there for an entirely different purpose. (In an effort to try to avoid mixing concepts).

https://github.com/GoodCloud/django-zebra/blob/master/zebra/utils.py#L17

@markstahler

So what exactly is the point of this function? I dont see any usage within Zebra and if it throws an exception when there is no subscription how do you check what kind of account status someone has through a template? I modified this function (as above) and created a template tag so I display templates based on current subscriptions. How are other accomplishing this same task?

@leetrout
Owner

The purpose of the function is to provide a single point for quickly determining the status of a given customer's subscription. Obviously we missed the use case where the subscription does not exist, as you pointed out above. In my project I'm still using the original version of the code we created and never ran in to this issue. I'm not using it at the template level since it does result in a call to Stripe, instead I call the function once at the beginning of a session and keep the result in the session.

I believe as it is currently written the functionality doesn't quite match the docstring, either. Originally the audit method returned a boolean and only support 3 states 5ce7d46#zebra/conf/defaults.py

The reason I don't want to mix concepts per your suggestion above is because if the exception is a key error it means there is a status which is unaccounted for in https://github.com/GoodCloud/django-zebra/blob/master/zebra/conf/options.py#L39 and I believe raising an exception in the case is the best thing to do so nothing slips by if Stripe updates their statuses.

All this to say it looks like this needs some much overdue attention and upon a closer examination there's a lot more we could do to correct the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.