Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) #1017 The screen is flickers while scrolling down #1039

Merged
merged 2 commits into from Dec 10, 2019

Conversation

@yaroslav-fedyshyn-nordwhale
Copy link
Contributor

yaroslav-fedyshyn-nordwhale commented Dec 6, 2019

Description

Use much simpler formula for displaying small or large header in onScroll handler of FeedList component on the Dashboard page.
It is fixes the flickering on all devices.

About #1017

How Has This Been Tested?

Open dashboard.
Try to scroll down and see if the header is flickering - it shouldn't.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request ( for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Videos:

Browser Simulators
https://www.screencast.com/t/iKqNFyAsE https://www.screencast.com/t/OQCuKcNKigjb
Copy link
Contributor

sirpy left a comment

still needs a debounce without user scroll
since changing header during scroll causes UI to hang

src/components/dashboard/Dashboard.js Show resolved Hide resolved
@yaroslav-fedyshyn-nordwhale

This comment has been minimized.

Copy link
Contributor Author

yaroslav-fedyshyn-nordwhale commented Dec 9, 2019

still needs a debounce without user scroll
since changing header during scroll causes UI to hang

I added debounce for the scroll handler. And here (https://www.screencast.com/t/AruOQojY51) you can see how it is working now.

@yaroslav-fedyshyn-nordwhale yaroslav-fedyshyn-nordwhale marked this pull request as ready for review Dec 10, 2019
Copy link
Contributor

AlexeyKosinski left a comment

image
@yaroslav-fedyshyn-nordwhale please fix max height on desktop

@yaroslav-fedyshyn-nordwhale

This comment has been minimized.

Copy link
Contributor Author

yaroslav-fedyshyn-nordwhale commented Dec 10, 2019

@AlexeyKosinski It might be some error/bug on your local machine. I tested this branch locally and on netlify deploy preview and the height is fine for both tests. Try to clean the cache.
Here is the screenshots of my test:

Local Netlify Deploy Preview
1 2
@sirpy sirpy merged commit 2c2a85f into master Dec 10, 2019
15 checks passed
15 checks passed
Header rules No header rules processed
Details
Header rules - gooddev No header rules processed
Details
Pages changed 9 new files uploaded
Details
Pages changed - gooddev 9 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Mixed content - gooddev No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
Redirect rules - gooddev 1 redirect rule processed
Details
Travis CI - Branch Build Passed
Details
codebeat no reportable quality changes
Details
coverage/coveralls Coverage remained the same at 46.984%
Details
deploy/netlify Deploy preview ready!
Details
netlify/gooddev/deploy-preview Deploy preview ready!
Details
@AlexeyKosinski

This comment has been minimized.

Copy link
Contributor

AlexeyKosinski commented Dec 10, 2019

4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.