Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bonus not received #1061

Merged
merged 2 commits into from Dec 16, 2019
Merged

Fix bonus not received #1061

merged 2 commits into from Dec 16, 2019

Conversation

@sirpy
Copy link
Contributor

sirpy commented Dec 15, 2019

Description

gdstore was bound to the state the effect was defined, so isLoggedInCitizen was always false
separate the bonus check interval into a new effect bound to gdstore
since we also call bonus check on init, if gdstore is false then check wallet.isCitizen

About #1060

sirpy added 2 commits Dec 15, 2019
…ed form initially bound state. also in initialize checked iscitizen from wallet since gdstore value is not updated inside effect
@sirpy

This comment has been minimized.

Copy link
Contributor Author

sirpy commented Dec 15, 2019

@AnastasiiaOdnoshevna do we have bonus test in automation?

Copy link
Contributor

yaroslav-fedyshyn-nordwhale left a comment

Tested on the local machine and netlify deploy preview server - Working well.

@sirpy sirpy merged commit d57bd14 into master Dec 16, 2019
15 checks passed
15 checks passed
Header rules No header rules processed
Details
Header rules - gooddev No header rules processed
Details
Pages changed 13 new files uploaded
Details
Pages changed - gooddev 7 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Mixed content - gooddev No mixed content detected
Details
Redirect rules 1 redirect rule processed
Details
Redirect rules - gooddev 1 redirect rule processed
Details
Travis CI - Branch Build Passed
Details
codebeat no reportable quality changes
Details
coverage/coveralls First build on fix-bonus-not-received at 46.933%
Details
deploy/netlify Deploy preview ready!
Details
netlify/gooddev/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.