upstreaming driver into Linux mainline #1

okias · 2022-07-09T21:46:05Z

Hello,

First and foremost, I'd like to thank you for making your driver available under a FOSS license that is compatible with the Linux kernel.

I assume this repository is connected to the official development of the tfa98xx driver. I would be interested if Goodix considered sending the patches directly into the Linux kernel. I assume it would be really beneficial for the customers to have a long-term supported upstream driver.

There is already some support for a few Goodix TFA98xx chips (for example, https://patchwork.kernel.org/project/alsa-devel/patch/20211024085840.1536438-5-vincent.knecht@mailoo.org/ ).

If there is some interest from Goodix, I believe the Linux community would be willing to help you with the inclusion process, providing testing and reviews.

Thank you!

Goodix-vas · 2022-07-12T06:25:16Z

Hello David Heidelberg, Thanks for your message. We will have an internal discussion to see how we can handle this and if its required. Met vriendelijke groet/Best regards, Danny Teunissen ***@***.*** E: ***@***.******@***.***> | Web: www.goodix.com<http://www.goodix.com/> Goodix Technology (Netherlands) B.V. Wijchenseweg 20, 6537 TL Nijmegen, Netherlands From: David Heidelberg ***@***.***> Sent: zaterdag 9 juli 2022 23:46 To: Goodix-vas/tfa98xx ***@***.***> Cc: Subscribed ***@***.***> Subject: [Goodix-vas/tfa98xx] upstreaming driver into Linux mainline (Issue #1) CAUTION: External Email. *** Do not click on any links or open any attachments unless you recognize the sender and know the content is safe. *** Hello, First and foremost, I'd like to thank you for making your driver available under a FOSS license that is compatible with the Linux kernel. I assume this repository is connected to the official development of the tfa98xx driver. I would be interested if Goodix considered sending the patches directly into the Linux kernel. I assume it would be really beneficial for the customers to have a long-term supported upstream driver. There is already some support for a few Goodix TFA98xx chips (for example, ***@***.***/ ). If there is some interest from Goodix, I believe the Linux community would be willing to help you with the inclusion process, providing testing and reviews. Thank you! — Reply to this email directly, view it on GitHub<#1>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ3ZGGP6OCXEHR5OQHMXKSDVTHXKRANCNFSM53D7ESPA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>

Temporary solution, until proper driver gets into mainline! Please, preferably do not waste time on improving except import or security/crash bugfixes. Rather invest time into upstreaming\ if possible. Need firmware (the one from j0sh1x works just fine). Imported with small adjustments: - `lib/ -> src/` - small few unimportant lines of changes to compile Imported from: https://github.com/j0sh1x/tfa98xx Discussion w/ Goodix about upstreaming: Goodix-vas/tfa98xx#1 Signed-off-by: David Heidelberg <david@ixit.cz>

Temporary solution, until proper driver gets into mainline! Please, preferably do not waste time on improving except import or security/crash bugfixes. Rather invest time into upstreaming if possible. Need firmware (the one from j0sh1x works just fine). Imported with small adjustments: - `{lib/,src/} -> tfa98xx-downstream/` - small few unimportant lines of changes to compile Imported from: https://github.com/j0sh1x/tfa98xx Discussion w/ Goodix about upstreaming: Goodix-vas/tfa98xx#1 Signed-off-by: David Heidelberg <david@ixit.cz>

Goodix-vas · 2022-07-21T08:46:09Z

Hello David Heidelberg, We have discussed internally, but we don’t have the resources to pursue this at the moment. Met vriendelijke groet/Best regards, Danny Teunissen ***@***.*** E: ***@***.******@***.***> | Web: www.goodix.com<http://www.goodix.com/> Goodix Technology (Netherlands) B.V. Wijchenseweg 20, 6537 TL Nijmegen, Netherlands From: Danny Teunissen Sent: dinsdag 12 juli 2022 08:25 To: Goodix-vas/tfa98xx ***@***.***> Subject: RE: [Goodix-vas/tfa98xx] upstreaming driver into Linux mainline (Issue #1) Hello David Heidelberg, Thanks for your message. We will have an internal discussion to see how we can handle this and if its required. Met vriendelijke groet/Best regards, Danny Teunissen ***@***.*** E: ***@***.******@***.***> | Web: www.goodix.com<http://www.goodix.com/> Goodix Technology (Netherlands) B.V. Wijchenseweg 20, 6537 TL Nijmegen, Netherlands From: David Heidelberg ***@***.******@***.***>> Sent: zaterdag 9 juli 2022 23:46 To: Goodix-vas/tfa98xx ***@***.******@***.***>> Cc: Subscribed ***@***.******@***.***>> Subject: [Goodix-vas/tfa98xx] upstreaming driver into Linux mainline (Issue #1) CAUTION: External Email. *** Do not click on any links or open any attachments unless you recognize the sender and know the content is safe. *** Hello, First and foremost, I'd like to thank you for making your driver available under a FOSS license that is compatible with the Linux kernel. I assume this repository is connected to the official development of the tfa98xx driver. I would be interested if Goodix considered sending the patches directly into the Linux kernel. I assume it would be really beneficial for the customers to have a long-term supported upstream driver. There is already some support for a few Goodix TFA98xx chips (for example, ***@***.***/ ). If there is some interest from Goodix, I believe the Linux community would be willing to help you with the inclusion process, providing testing and reviews. Thank you! — Reply to this email directly, view it on GitHub<#1>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ3ZGGP6OCXEHR5OQHMXKSDVTHXKRANCNFSM53D7ESPA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>

okias · 2022-07-21T17:16:00Z

Hello Danny,

thank you for reply.

Would it be possible to at least provide documentation for TFA98xx family or at least TFA9894 (which is used in the Snapdragon-based OnePlus 6T and others)? In case an NDA is required, I believe some team members would be willing to sign it.

Best regards
David

okias · 2022-08-05T14:23:48Z

Kind reminder.

Goodix-vas · 2022-08-08T04:50:46Z

Dear David, Please find information on the tfa9894 on our company website: https://product.goodix.com/en/product/tfa_9894 Met vriendelijke groet/Best regards, Danny Teunissen ***@***.*** E: ***@***.******@***.***> | Web: www.goodix.com<http://www.goodix.com/> Goodix Technology (Netherlands) B.V. Wijchenseweg 20, 6537 TL Nijmegen, Netherlands From: David Heidelberg ***@***.***> Sent: vrijdag 5 augustus 2022 16:24 To: Goodix-vas/tfa98xx ***@***.***> Cc: Danny Teunissen ***@***.***>; Comment ***@***.***> Subject: Re: [Goodix-vas/tfa98xx] upstreaming driver into Linux mainline (Issue #1) CAUTION: External Email. *** Do not click on any links or open any attachments unless you recognize the sender and know the content is safe. *** Kind reminder. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ3ZGGKADBIHLITEKFMPBLTVXUPX5ANCNFSM53D7ESPA>. You are receiving this because you commented.Message ID: ***@***.******@***.***>>

Temporary solution, until proper driver gets into mainline! Please, preferably do not waste time on improving except import or security/crash bugfixes. Rather invest time into upstreaming if possible. Need firmware (the one from j0sh1x works just fine). Imported with small adjustments: - `{lib/,src/} -> tfa98xx-downstream/` - small few unimportant lines of changes to compile Imported from: https://github.com/j0sh1x/tfa98xx Discussion w/ Goodix about upstreaming: Goodix-vas/tfa98xx#1 Signed-off-by: David Heidelberg <david@ixit.cz>

Temporary solution, until proper driver gets into mainline! Please, preferably do not waste time on improving except import or security/crash bugfixes. Rather invest time into upstreaming if possible. Need firmware (the one from j0sh1x works just fine). Imported with small adjustments: - `{lib/,src/} -> tfa98xx-downstream/` - small few unimportant lines of changes to compile Imported from: https://github.com/j0sh1x/tfa98xx Discussion w/ Goodix about upstreaming: Goodix-vas/tfa98xx#1 Signed-off-by: David Heidelberg <david@ixit.cz> tfa98xx: use devm_gpiod_put instead of deprecated devm_gpio_free The devm_gpio_free is completely removed in 6.0. Check the below patch https://lore.kernel.org/lkml/CAMRc=Mfqo19we+0ShbpCtbbsXgU6trKbwQR2Zg7LcAWSJ_834A@mail.gmail.com/T/ Temporarily convert gpio to gpio_desc and use devm_gpiod_put to release the gpio. Eventually we will have to move to the new gpiod api. sound: codecs: tfa98xx: fix .remove decleration