Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

can't launch github-auth sample on Chrome 32.0.1700.77, OSX 10.9.1 #185

Closed
kompiro opened this Issue Jan 19, 2014 · 4 comments

Comments

Projects
None yet
5 participants

kompiro commented Jan 19, 2014

How to reproduce

  1. Install GitHub Auth Sample
  2. Launch it from Chrome App
  3. Click sign in button (open new window for signing in GitHub and authorizing the app)
  4. Sign in to GitHub and authorize the application
  5. The opening window is closed, But the app window is still showed sign in button

Debuging

chrome.identity.launchWebAuthFlow's callback function doesn't get correct redirectUri.
Is it GitHub issue? or launchWebAuthFlow's problem?

Member

beaufortfrancois commented Jan 21, 2014

From what I can see, the GitHub App is redirecting to https://peohaiphmbeogddbmbfdldgjnmdnpban.chromiumapp.org/ which does not match the Webstore App ID (laolmfhjaobpboigjfbclcphckmjodlp).

However, if you clone the repo and load the GitHub Auth Sample as an unpacked extension, it works great!

@mangini Can you tell us more?

@mangini mangini was assigned by scheib May 30, 2014

@kalman kalman added the bug label Jun 21, 2014

kalman commented Jun 21, 2014

(I haven't tried to verify this)

Member

dinhviethoa commented Jul 15, 2014

I verified that the app on the webstore doesn't show my repos.
Here's the logs I got in the console.

hrWithAuth GET https://api.github.com/user false index.js:126
launchWebAuthFlow completed Object undefined index.js:35
token fetch Errormessage: "[object Object]"stack: (...)get stack: function () { [native code] }set stack: function () { [native code] }__proto__: d undefined index.js:131
infoFetch failed Error undefined index.js:194
launchWebAuthFlow completed Object undefined 

It looks like chrome.identity.launchWebAuthFlow() is failing with "User interaction required.".

When loading the unpacked app, it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment