Improved drag&drop behavior #1269

Merged
merged 3 commits into from Mar 10, 2014

Projects

None yet

2 participants

@dinhviethoa
Member
  • Copy when files are dropped across project boundaries

fixed #1194

review: @devoncarew

@devoncarew devoncarew commented on an outdated diff Mar 10, 2014
ide/app/lib/workspace.dart
@@ -756,6 +756,14 @@ class Folder extends Container {
});
});
}
+
+ Future importResource(Resource res) {
@devoncarew
devoncarew Mar 10, 2014 Contributor

This is a copy from a different part of the workspace? Perhaps add some dartdoc to that effect?

Also, we way want to rename some methods to clarify the types that they take. importResource operates on a workspace resource; importFile and importFolder both operate on DOM filesystem entries. Perhaps change the 2nd two methods to importFileEntry and importDirectoryEntry for clarity?

@devoncarew
Contributor

lgtm

@dinhviethoa dinhviethoa merged commit c7193e9 into GoogleChrome:master Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment