Lighthouse score fails to score HTTPS properly #204

Closed
juliantoledo opened this Issue Sep 30, 2016 · 16 comments

Projects

None yet

4 participants

@juliantoledo
Collaborator

At the moment our Lighthouse score fails to score HTTPS properly, the reason is that we are using a server side version of Lighthouse called Moonlight that has a bug on the HTTPS scoring.

We are working with the Lighthouse team to solve it soon.

@juliantoledo juliantoledo added the bug label Sep 30, 2016
@juliantoledo juliantoledo added this to the v1.0 - I'm a PWA!! milestone Oct 3, 2016
@x1ddos
Member
x1ddos commented Oct 4, 2016

@juliantoledo can you assign this to me? I'm working on updating server-side version. Hopefully it'll fix the issue.

@juliantoledo
Collaborator

Sure @x1ddos, thank you!

@x1ddos
Member
x1ddos commented Oct 5, 2016

It feels like an issue with headless chrome after all.
I posted a question to headless-dev: https://groups.google.com/a/chromium.org/d/topic/headless-dev/RqxZAsYra0Y/discussion

@adewale
Collaborator
adewale commented Oct 26, 2016
@abdonrd
abdonrd commented Nov 24, 2016

Any news?

@x1ddos
Member
x1ddos commented Nov 24, 2016

@abdonrd The underlying issue has been finally resolved a few days ago. I will pull in the changes and see whether it fixes this bug.

Will update this thread soon.

@abdonrd
abdonrd commented Nov 24, 2016

Nice! Thanks @x1ddos!

@x1ddos
Member
x1ddos commented Nov 29, 2016

Good news, https://airhorner.com/ now scores 97/100 on moonlight and has passes HTTPS checks:

image

@x1ddos x1ddos closed this Nov 29, 2016
@abdonrd
abdonrd commented Nov 29, 2016

Nice! ๐ŸŽ‰

@juliantoledo
Collaborator

@x1ddos Great!!! I will update our server.

@x1ddos
Member
x1ddos commented Nov 29, 2016

@juliantoledo I'll start the OSS process for moonlight.

@juliantoledo
Collaborator

@x1ddos Thank you for your work on moonlight!

Deployed your new version to our server, it will take about 1 hour to score all PWAs again.

@abdonrd
abdonrd commented Dec 2, 2016

Yay! Thanks @juliantoledo!

@abdonrd
abdonrd commented Dec 2, 2016

Why the differences in Gulliver and Lighthouse extension?

Gulliver: 91
https://pwa-directory.appspot.com/pwas/5761645611581440

Lighthouse extension: 97
screen shot 2016-12-02 at 12 20 51

@juliantoledo
Collaborator

@abdonrd we use a version of Lighthouse built on Headless Chromium which enables it to run as a server app, for that reason our Lighthouse score and report may deviate from the standard Lighthouse Chrome extension. We are trying to get as close as possible, the major issue we had was the HTTPS detection, but we still need to look into other broken signals.

@adewale
Collaborator
adewale commented Dec 2, 2016

Please file bugs for any differences you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment