New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support production monitoring use case, no git required #5
Comments
New better idea: |
we're punting on non-git cases for MVP |
@patrickhulce Does that mean in general, that lighthouse-ci will work without a project's git repository when using a timestamp based versioning? It would be nice to just run |
This broader effort we refer to as "production monitoring" which is on our roadmap but requires many subtle but important changes to the types of UI and assumptions made in the CI server currently. We're discussing internally exactly how we want to handle this. |
Just placing my support behind this Issue |
@patrickhulce would this be just a new Project under the current UI? |
@Zizzamia yeah you can basically do a new project and fake the build context to get this to work today. Something like the below (copied from #225) export LHCI_BUILD_CONTEXT__CURRENT_HASH=$(node -p "new Date().getTime().toString(16).split('').reverse().join('')")
export LHCI_BUILD_CONTEXT__COMMIT_TIME=$(date --iso-8601=seconds)
export LHCI_BUILD_CONTEXT__CURRENT_BRANCH=master
export LHCI_BUILD_CONTEXT__COMMIT_MESSAGE="Periodic run "
export LHCI_BUILD_CONTEXT__AUTHOR="No one <noreply@example.com>"
export LHCI_BUILD_CONTEXT__AVATAR_URL="https://picsum.photos/id/237/200/200"
lhci ... |
@patrickhulce I have a quick question on tracking production URLs. Before that, let me explain about the setup we have currently. We have a repository with a
After reading the documentation and this comment, I see we can add a server key. I'm curious about two things:
...or am I being completely off my rocker here |
It seems you've mixed the two use cases together @kunalnagar. #342 was about monitoring production URLs without a git repository at all. You just configure
I'm not sure what you mean by storage key in the context of the config you shared. If you're talking about the server's configuration then you must specify a storage key or it will simply fail. There's no such thing as the server without any storage mechanism. If you're talking about where does data go if you don't configure an upload step, then the answer is nowhere, it will just stay on in your local CI.
Cron doesn't run from the CI process CLI, it runs on the server. |
@patrickhulce thanks a lot for the clarification!
Here's a simplified github action script that i am using as per your comment:
|
This has ventured a little too far into "build my setup" territory sorry @kunalnagar |
@patrickhulce no worries thanks for all the help! I was just trying to understand if there's an issue with how Github Actions handles environment variables OR how the |
this tweak is awesome |
is there a better way to do this in 2022? and how to do the env var hack with treosh/lighthouse-ci-action ? |
Currently every build needs a
.hash
but we don't necessarily need one. We could switch to a.projectVersion
and support timestamps instead?The text was updated successfully, but these errors were encountered: