From 2fbcedac825c163def928e586a5a62fa187fa8a4 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Wed, 14 Dec 2016 11:46:58 -0800 Subject: [PATCH] update eslint version for extension to match core make extension linting failures fail build as well --- lighthouse-extension/gulpfile.js | 3 ++- lighthouse-extension/package.json | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lighthouse-extension/gulpfile.js b/lighthouse-extension/gulpfile.js index 968355cd8e37..20e06db7ca15 100644 --- a/lighthouse-extension/gulpfile.js +++ b/lighthouse-extension/gulpfile.js @@ -50,7 +50,8 @@ gulp.task('lint', () => { 'gulpfile.js' ]) .pipe(eslint()) - .pipe(eslint.format()); + .pipe(eslint.format()) + .pipe(eslint.failAfterError()); }); gulp.task('images', () => { diff --git a/lighthouse-extension/package.json b/lighthouse-extension/package.json index 1052d8479949..3f2e3aefd8c2 100644 --- a/lighthouse-extension/package.json +++ b/lighthouse-extension/package.json @@ -12,11 +12,10 @@ "brfs": "^1.4.3", "browserify": "^13.0.0", "del": "^2.2.0", - "eslint-config-xo": "^0.10.1", "gulp": "^3.9.1", "gulp-chrome-manifest": "0.0.13", "gulp-debug": "^2.1.2", - "gulp-eslint": "^2.0.0", + "gulp-eslint": "^3.0.1", "gulp-livereload": "^3.8.1", "gulp-tap": "^0.1.3", "gulp-util": "^3.0.7",