diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap index 239544b41b9c..8c7a4b43a2b0 100644 --- a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap +++ b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap @@ -171,9 +171,6 @@ Object { Object { "path": "unsized-images", }, - Object { - "path": "large-javascript-libraries", - }, Object { "path": "valid-source-maps", }, @@ -1036,11 +1033,6 @@ Object { "id": "unsized-images", "weight": 0, }, - Object { - "group": "diagnostics", - "id": "large-javascript-libraries", - "weight": 0, - }, Object { "id": "network-requests", "weight": 0, diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index 9aa56fa235b4..a5945cda7470 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -242,7 +242,6 @@ const defaultConfig = { 'no-unload-listeners', 'non-composited-animations', 'unsized-images', - 'large-javascript-libraries', 'valid-source-maps', 'manual/pwa-cross-browser', 'manual/pwa-page-transitions', @@ -475,7 +474,6 @@ const defaultConfig = { {id: 'long-tasks', weight: 0, group: 'diagnostics'}, {id: 'non-composited-animations', weight: 0, group: 'diagnostics'}, {id: 'unsized-images', weight: 0, group: 'diagnostics'}, - {id: 'large-javascript-libraries', weight: 0, group: 'diagnostics'}, // Audits past this point don't belong to a group and will not be shown automatically {id: 'network-requests', weight: 0}, {id: 'network-rtt', weight: 0}, diff --git a/lighthouse-core/config/experimental-config.js b/lighthouse-core/config/experimental-config.js index 2c7519602186..ecc9cf0f9f57 100644 --- a/lighthouse-core/config/experimental-config.js +++ b/lighthouse-core/config/experimental-config.js @@ -16,6 +16,7 @@ const config = { audits: [ 'autocomplete', 'full-page-screenshot', + 'large-javascript-libraries', ], passes: [{ passName: 'defaultPass', @@ -24,6 +25,13 @@ const config = { ], }], categories: { + // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default + // config is awkward - easier to omit the property here. Will defer to default config. + 'performance': { + auditRefs: [ + {id: 'large-javascript-libraries', weight: 0, group: 'diagnostics'}, + ], + }, // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default // config is awkward - easier to omit the property here. Will defer to default config. 'best-practices': { diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 2a6f7d48ed55..f35ea782bde8 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -2059,20 +2059,6 @@ ] } }, - "large-javascript-libraries": { - "id": "large-javascript-libraries", - "title": "Avoids large JavaScript libraries with smaller alternatives", - "description": "Large JavaScript libraries can lead to poor performance. Prefer smaller, functionally equivalent libraries to reduce your bundle size. [Learn more](https://developers.google.com/web/fundamentals/performance/webpack/decrease-frontend-size#optimize_dependencies).", - "score": 1, - "scoreDisplayMode": "binary", - "displayValue": "0 large libraries found", - "details": { - "type": "table", - "headings": [], - "items": [], - "summary": {} - } - }, "valid-source-maps": { "id": "valid-source-maps", "title": "Page has valid source maps", @@ -4676,11 +4662,6 @@ "weight": 0, "group": "diagnostics" }, - { - "id": "large-javascript-libraries", - "weight": 0, - "group": "diagnostics" - }, { "id": "network-requests", "weight": 0 @@ -5880,12 +5861,6 @@ "duration": 100, "entryType": "measure" }, - { - "startTime": 0, - "name": "lh:audit:large-javascript-libraries", - "duration": 100, - "entryType": "measure" - }, { "startTime": 0, "name": "lh:audit:valid-source-maps", @@ -7238,20 +7213,6 @@ "audits[object-alt].details.headings[0].text", "audits[password-inputs-can-be-pasted-into].details.headings[0].text" ], - "lighthouse-core/audits/large-javascript-libraries.js | title": [ - "audits[large-javascript-libraries].title" - ], - "lighthouse-core/audits/large-javascript-libraries.js | description": [ - "audits[large-javascript-libraries].description" - ], - "lighthouse-core/audits/large-javascript-libraries.js | displayValue": [ - { - "values": { - "libraryCount": 0 - }, - "path": "audits[large-javascript-libraries].displayValue" - } - ], "lighthouse-core/audits/valid-source-maps.js | title": [ "audits[valid-source-maps].title" ], diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt index 57304d5d24dc..30b8393bfba4 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt @@ -2,11 +2,11 @@ Tests that exporting works. ++++++++ testExportHtml -# of .lh-audit divs (original): 136 +# of .lh-audit divs (original): 135 -# of .lh-audit divs (exported html): 136 +# of .lh-audit divs (exported html): 135 ++++++++ testExportJson -# of audits (json): 152 +# of audits (json): 151 diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt index f80c6a402c7b..b98bb689541f 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt @@ -247,7 +247,6 @@ Auditing: Avoid long main-thread tasks Auditing: Avoids `unload` event listeners Auditing: Avoid non-composited animations Auditing: Image elements have explicit `width` and `height` -Auditing: Avoids large JavaScript libraries with smaller alternatives Auditing: Page has valid source maps Auditing: Site works cross-browser Auditing: Page transitions don't feel like they block on the network @@ -474,7 +473,6 @@ is-crawlable: pass is-on-https: pass js-libraries: pass label: notApplicable -large-javascript-libraries: pass largest-contentful-paint: numeric largest-contentful-paint-element: informative layout-shift-elements: notApplicable @@ -566,5 +564,5 @@ visual-order-follows-dom: manual without-javascript: pass works-offline: fail -# of .lh-audit divs: 156 +# of .lh-audit divs: 155 diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run-expected.txt index 8628b1c89fb0..7340ef0369c0 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run-expected.txt @@ -27,7 +27,6 @@ first-cpu-idle first-meaningful-paint font-display interactive -large-javascript-libraries largest-contentful-paint largest-contentful-paint-element layout-shift-elements