diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap index 8c7a4b43a2b0..f1000374f543 100644 --- a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap +++ b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap @@ -399,6 +399,9 @@ Object { Object { "path": "dobetterweb/geolocation-on-start", }, + Object { + "path": "dobetterweb/has-inspector-issues", + }, Object { "path": "dobetterweb/no-document-write", }, @@ -797,6 +800,11 @@ Object { "id": "valid-source-maps", "weight": 0, }, + Object { + "group": "best-practices-general", + "id": "has-inspector-issues", + "weight": 1, + }, ], "title": "Best Practices", }, diff --git a/lighthouse-core/audits/dobetterweb/has-inspector-issues.js b/lighthouse-core/audits/dobetterweb/has-inspector-issues.js new file mode 100644 index 000000000000..e41c2d552a11 --- /dev/null +++ b/lighthouse-core/audits/dobetterweb/has-inspector-issues.js @@ -0,0 +1,192 @@ +/** + * @license Copyright 2020 The Lighthouse Authors. All Rights Reserved. + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + */ + +/** + * @fileoverview Audits a page to determine whether it generates issues in the Issues panel of Chrome Devtools. + * The audit is meant to maintain parity with the Chrome Devtools Issues panel front end. + * https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/sdk/ + */ + +'use strict'; + +/** @typedef {{url: string}} IssueSubItem */ +/** @typedef {{issueType: string|LH.IcuMessage, subItems: Array}} IssueItem */ + +const Audit = require('../audit.js'); +const i18n = require('../../lib/i18n/i18n.js'); + +const UIStrings = { + /** Title of a Lighthouse audit that provides detail on various types of problems with a website, like security or network errors. This descriptive title is shown to users when no issues were logged into the Chrome DevTools Issues panel. */ + title: 'No issues in the `Issues` panel in Chrome Devtools', + /** Title of a Lighthouse audit that provides detail on various types of problems with a website, like security or network errors. This descriptive title is shown to users when issues are detected and logged into the Chrome DevTools Issues panel. */ + failureTitle: 'Issues were logged in the `Issues` panel in Chrome Devtools', + /* eslint-disable max-len */ + /** Description of a Lighthouse audit that tells the user why issues being logged to the Chrome DevTools Issues panel are a cause for concern and so should be fixed. This is displayed after a user expands the section to see more. No character length limits. */ + description: 'Issues logged to the `Issues` panel in Chrome Devtools indicate unresolved problems. They can come from network request failures, insufficient security controls, and other browser concerns. Open up the Issues panel in Chrome DevTools for more details on each issue.', + /* eslint-enable max-len */ + /** Table column header for the types of problems observed in a website, like security or network errors. */ + columnIssueType: 'Issue type', + /** The type of an Issue in Chrome DevTools when a resource is blocked due to the website's cross-origin policy. */ + issueTypeBlockedByResponse: 'Blocked by cross-origin policy', + /** The type of an Issue in Chrome DevTools when a site has large ads that use up a lot of the browser's resources. */ + issueTypeHeavyAds: 'Heavy resource usage by ads', +}; + +const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); + +class IssuesPanelEntries extends Audit { + /** + * @return {LH.Audit.Meta} + */ + static get meta() { + return { + id: 'has-inspector-issues', + title: str_(UIStrings.title), + failureTitle: str_(UIStrings.failureTitle), + description: str_(UIStrings.description), + requiredArtifacts: ['InspectorIssues'], + }; + } + + /** + * @param {Array} mixedContentIssues + * @return {LH.Audit.Details.TableItem} + */ + static getMixedContentRow(mixedContentIssues) { + const requestUrls = new Set(); + for (const issue of mixedContentIssues) { + const requestUrl = (issue.request && issue.request.url) || issue.mainResourceURL; + requestUrls.add(requestUrl); + } + return { + issueType: 'Mixed content', + subItems: { + type: 'subitems', + items: Array.from(requestUrls).map(url => ({url})), + }, + }; + } + + /** + * @param {Array} sameSiteCookieIssues + * @return {LH.Audit.Details.TableItem} + */ + static getSameSiteCookieRow(sameSiteCookieIssues) { + const requestUrls = new Set(); + for (const issue of sameSiteCookieIssues) { + const requestUrl = (issue.request && issue.request.url) || issue.cookieUrl; + if (requestUrl) { + requestUrls.add(requestUrl); + } + } + return { + issueType: 'SameSite cookie', + subItems: { + type: 'subitems', + items: Array.from(requestUrls).map(url => { + return { + url, + }; + }), + }, + }; + } + + /** + * @param {Array} blockedByResponseIssues + * @return {LH.Audit.Details.TableItem} + */ + static getBlockedByResponseRow(blockedByResponseIssues) { + const requestUrls = new Set(); + for (const issue of blockedByResponseIssues) { + const requestUrl = issue.request && issue.request.url; + if (requestUrl) { + requestUrls.add(requestUrl); + } + } + return { + issueType: str_(UIStrings.issueTypeBlockedByResponse), + subItems: { + type: 'subitems', + items: Array.from(requestUrls).map(url => { + return { + url, + }; + }), + }, + }; + } + + /** + * @param {Array} cspIssues + * @return {LH.Audit.Details.TableItem} + */ + static getContentSecurityPolicyRow(cspIssues) { + const requestUrls = new Set(); + for (const issue of cspIssues) { + const requestUrl = issue.blockedURL; + if (requestUrl) { + requestUrls.add(requestUrl); + } + } + return { + issueType: 'Content security policy', + subItems: { + type: 'subitems', + items: Array.from(requestUrls).map(url => { + return { + url, + }; + }), + }, + }; + } + + /** + * @param {LH.Artifacts} artifacts + * @return {LH.Audit.Product} + */ + static audit(artifacts) { + /** @type {LH.Audit.Details.Table['headings']} */ + const headings = [ + /* eslint-disable max-len */ + {key: 'issueType', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: str_(UIStrings.columnIssueType)}, + /* eslint-enable max-len */ + ]; + + const issues = artifacts.InspectorIssues; + /** @type LH.Audit.Details.TableItem[] */ + const items = []; + + if (issues.mixedContent.length) { + items.push(this.getMixedContentRow(issues.mixedContent)); + } + if (issues.sameSiteCookies.length) { + items.push(this.getSameSiteCookieRow(issues.sameSiteCookies)); + } + if (issues.blockedByResponse.length) { + items.push(this.getBlockedByResponseRow(issues.blockedByResponse)); + } + if (issues.heavyAds.length) { + items.push({issueType: str_(UIStrings.issueTypeHeavyAds)}); + } + const cspIssues = issues.contentSecurityPolicy.filter(issue => { + // kTrustedTypesSinkViolation and kTrustedTypesPolicyViolation aren't currently supported by the Issues panel + return issue.contentSecurityPolicyViolationType !== 'kTrustedTypesSinkViolation' && + issue.contentSecurityPolicyViolationType !== 'kTrustedTypesPolicyViolation'; + }); + if (cspIssues.length) { + items.push(this.getContentSecurityPolicyRow(cspIssues)); + } + return { + score: items.length > 0 ? 0 : 1, + details: Audit.makeTableDetails(headings, items), + }; + } +} + +module.exports = IssuesPanelEntries; +module.exports.UIStrings = UIStrings; diff --git a/lighthouse-core/audits/errors-in-console.js b/lighthouse-core/audits/errors-in-console.js index 5e574e63ed39..5fe95b89c9c8 100644 --- a/lighthouse-core/audits/errors-in-console.js +++ b/lighthouse-core/audits/errors-in-console.js @@ -23,8 +23,6 @@ const UIStrings = { description: 'Errors logged to the console indicate unresolved problems. ' + 'They can come from network request failures and other browser concerns. ' + '[Learn more](https://web.dev/errors-in-console/)', - /** Label for a column in a data table; entries in the column will be the descriptions of logged browser errors. */ - columnDesc: 'Description', }; const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); @@ -116,7 +114,7 @@ class ErrorLogs extends Audit { /** @type {LH.Audit.Details.Table['headings']} */ const headings = [ {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)}, - {key: 'description', itemType: 'code', text: str_(UIStrings.columnDesc)}, + {key: 'description', itemType: 'code', text: str_(i18n.UIStrings.columnDescription)}, ]; const details = Audit.makeTableDetails(headings, tableRows); diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index a5945cda7470..3a2edc0858af 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -318,6 +318,7 @@ const defaultConfig = { 'dobetterweb/dom-size', 'dobetterweb/external-anchors-use-rel-noopener', 'dobetterweb/geolocation-on-start', + 'dobetterweb/has-inspector-issues', 'dobetterweb/no-document-write', 'dobetterweb/no-vulnerable-libraries', 'dobetterweb/js-libraries', @@ -572,6 +573,7 @@ const defaultConfig = { {id: 'deprecations', weight: 1, group: 'best-practices-general'}, {id: 'errors-in-console', weight: 1, group: 'best-practices-general'}, {id: 'valid-source-maps', weight: 0, group: 'best-practices-general'}, + {id: 'has-inspector-issues', weight: 1, group: 'best-practices-general'}, ], }, 'seo': { diff --git a/lighthouse-core/gather/gatherers/inspector-issues.js b/lighthouse-core/gather/gatherers/inspector-issues.js index 29a54cf5cecf..c51fc7982703 100644 --- a/lighthouse-core/gather/gatherers/inspector-issues.js +++ b/lighthouse-core/gather/gatherers/inspector-issues.js @@ -50,17 +50,51 @@ class InspectorIssues extends Gatherer { const artifact = { /** @type {Array} */ mixedContent: [], + /** @type {Array} */ + sameSiteCookies: [], + /** @type {Array} */ + blockedByResponse: [], + /** @type {Array} */ + heavyAds: [], + /** @type {Array} */ + contentSecurityPolicy: [], }; for (const issue of this._issues) { if (issue.details.mixedContentIssueDetails) { const issueDetails = issue.details.mixedContentIssueDetails; const issueReqId = issueDetails.request && issueDetails.request.requestId; + // Duplicate issues can occur for the same request; only use the one with a matching networkRequest. if (issueReqId && networkRecords.find(req => req.requestId === issueReqId)) { - artifact.mixedContent.push(issue.details.mixedContentIssueDetails); + artifact.mixedContent.push(issueDetails); } } + if (issue.details.sameSiteCookieIssueDetails) { + const issueDetails = issue.details.sameSiteCookieIssueDetails; + const issueReqId = issueDetails.request && issueDetails.request.requestId; + // Duplicate issues can occur for the same request; only use the one with a matching networkRequest. + if (issueReqId && + networkRecords.find(req => req.requestId === issueReqId)) { + artifact.sameSiteCookies.push(issueDetails); + } + } + if (issue.details.blockedByResponseIssueDetails) { + const issueDetails = issue.details.blockedByResponseIssueDetails; + const issueReqId = issueDetails.request && issueDetails.request.requestId; + // Duplicate issues can occur for the same request; only use the one with a matching networkRequest. + if (issueReqId && + networkRecords.find(req => req.requestId === issueReqId)) { + artifact.blockedByResponse.push(issueDetails); + } + } + if (issue.details.heavyAdIssueDetails) { + artifact.heavyAds.push(issue.details.heavyAdIssueDetails); + } + // Duplicate issues can occur for the same request; only use the one with a matching networkRequest. + if (issue.details.contentSecurityPolicyIssueDetails) { + artifact.contentSecurityPolicy.push(issue.details.contentSecurityPolicyIssueDetails); + } } return artifact; diff --git a/lighthouse-core/lib/i18n/i18n.js b/lighthouse-core/lib/i18n/i18n.js index 99a1317270ea..e24ad2d9a4ca 100644 --- a/lighthouse-core/lib/i18n/i18n.js +++ b/lighthouse-core/lib/i18n/i18n.js @@ -90,6 +90,8 @@ const UIStrings = { columnDuration: 'Duration', /** Label for a column in a data table; entries will be a representation of a DOM element that did not meet certain suggestions. */ columnFailingElem: 'Failing Elements', + /** Label for a column in a data table; entries will be a description of the table item. */ + columnDescription: 'Description', /** Label for a row in a data table; entries will be the total number and byte size of all resources loaded by a web page. */ totalResourceType: 'Total', /** Label for a row in a data table; entries will be the total number and byte size of all 'Document' resources loaded by a web page. */ diff --git a/lighthouse-core/lib/i18n/locales/ar-XB.json b/lighthouse-core/lib/i18n/locales/ar-XB.json index d7170724e875..ef13d6d58c7a 100644 --- a/lighthouse-core/lib/i18n/locales/ar-XB.json +++ b/lighthouse-core/lib/i18n/locales/ar-XB.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "‏‮Uses‬‏ ‏‮passive‬‏ ‏‮listeners‬‏ ‏‮to‬‏ ‏‮improve‬‏ ‏‮scrolling‬‏ ‏‮performance‬‏" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "‏‮Description‬‏" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "‏‮Errors‬‏ ‏‮logged‬‏ ‏‮to‬‏ ‏‮the‬‏ ‏‮console‬‏ ‏‮indicate‬‏ ‏‮unresolved‬‏ ‏‮problems‬‏. ‏‮They‬‏ ‏‮can‬‏ ‏‮come‬‏ ‏‮from‬‏ ‏‮network‬‏ ‏‮request‬‏ ‏‮failures‬‏ ‏‮and‬‏ ‏‮other‬‏ ‏‮browser‬‏ ‏‮concerns‬‏. [‏‮Learn‬‏ ‏‮more‬‏](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ar.json b/lighthouse-core/lib/i18n/locales/ar.json index 9b63a2b77b3f..abfd233d231f 100644 --- a/lighthouse-core/lib/i18n/locales/ar.json +++ b/lighthouse-core/lib/i18n/locales/ar.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "يتم استخدام أدوات معالجة الحدث السلبية لتحسين أداء التمرير" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "الوصف" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "تشير الأخطاء التي تم تسجيلها في وحدة التحكّم إلى مشاكل لم يتم حلها. قد تنتج هذه المشاكل من إخفاقات طلب الشبكة ومشاكل أخرى تتعلق بالمتصفّح. [مزيد من المعلومات](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/bg.json b/lighthouse-core/lib/i18n/locales/bg.json index acd55ddd20a4..60f724851e79 100644 --- a/lighthouse-core/lib/i18n/locales/bg.json +++ b/lighthouse-core/lib/i18n/locales/bg.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Използва пасивни приематели на събития за подобряване на ефективността при превъртане" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Описание" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Грешките, записани в конзолата, показват нерешени проблеми. Те може да се дължат на неуспешни заявки за мрежата и други проблеми в браузъра. [Научете повече](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ca.json b/lighthouse-core/lib/i18n/locales/ca.json index b1be17703c91..9f952014f8d2 100644 --- a/lighthouse-core/lib/i18n/locales/ca.json +++ b/lighthouse-core/lib/i18n/locales/ca.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Utilitza detectors passius per millorar el rendiment del desplaçament" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descripció" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Els errors registrats a la consola indiquen problemes pendents de resoldre. Poden provenir d'errors de sol·licitud de la xarxa i d'altres problemes del navegador. [Més informació](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/cs.json b/lighthouse-core/lib/i18n/locales/cs.json index c539663e4620..47292d80d277 100644 --- a/lighthouse-core/lib/i18n/locales/cs.json +++ b/lighthouse-core/lib/i18n/locales/cs.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Používá pasivní posluchače, které zlepšují posouvání" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Popis" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Chyby zaprotokolované do konzole ukazují na nevyřešené problémy. Mohou pocházet ze selhání síťových požadavků nebo jiných problémů v prohlížeči. [Další informace](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/da.json b/lighthouse-core/lib/i18n/locales/da.json index 17b148508052..2743e0de691b 100644 --- a/lighthouse-core/lib/i18n/locales/da.json +++ b/lighthouse-core/lib/i18n/locales/da.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Anvender passive hændelsesfunktioner til at forbedre rulning" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Beskrivelse" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Fejl, der er logført i konsollen, angiver uløste problemer. De kan stamme fra mislykkede netværksanmodninger og andre browserproblemer. [Få flere oplysninger](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/de.json b/lighthouse-core/lib/i18n/locales/de.json index fd375ec15feb..114fb1349a3b 100644 --- a/lighthouse-core/lib/i18n/locales/de.json +++ b/lighthouse-core/lib/i18n/locales/de.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Verwendet passive Listener zur Verbesserung der Scrollleistung" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Beschreibung" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "In der Konsole protokollierte Fehler weisen auf ungelöste Probleme hin. Sie können durch fehlgeschlagene Netzwerkanfragen und andere Browser-Probleme verursacht werden. [Weitere Informationen](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/el.json b/lighthouse-core/lib/i18n/locales/el.json index f4547e03d016..38402bf19cd9 100644 --- a/lighthouse-core/lib/i18n/locales/el.json +++ b/lighthouse-core/lib/i18n/locales/el.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Χρησιμοποιεί παθητικές λειτουργίες επεξεργασίας συμβάντων για τη βελτίωση της απόδοσης κύλισης" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Περιγραφή" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Τα σφάλματα που έχουν καταγραφεί στην κονσόλα υποδεικνύουν ότι υπάρχουν προβλήματα τα οποία δεν έχουν επιλυθεί. Μπορεί να σχετίζονται με σφάλματα αιτημάτων δικτύου ή με άλλα ζητήματα του προγράμματος περιήγησης. [Μάθετε περισσότερα](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/en-GB.json b/lighthouse-core/lib/i18n/locales/en-GB.json index 77b70f84f8fb..2f6d5fe3d3ce 100644 --- a/lighthouse-core/lib/i18n/locales/en-GB.json +++ b/lighthouse-core/lib/i18n/locales/en-GB.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Uses passive listeners to improve scrolling performance" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Description" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Errors logged to the console indicate unresolved problems. They can come from network request failures and other browser concerns. [Learn more](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/en-US.json b/lighthouse-core/lib/i18n/locales/en-US.json index ef5aa6818ad0..6a145262fee6 100644 --- a/lighthouse-core/lib/i18n/locales/en-US.json +++ b/lighthouse-core/lib/i18n/locales/en-US.json @@ -665,6 +665,24 @@ "lighthouse-core/audits/dobetterweb/geolocation-on-start.js | title": { "message": "Avoids requesting the geolocation permission on page load" }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | columnIssueType": { + "message": "Issue type" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | description": { + "message": "Issues logged to the `Issues` panel in Chrome Devtools indicate unresolved problems. They can come from network request failures, insufficient security controls, and other browser concerns. Open up the Issues panel in Chrome DevTools for more details on each issue." + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | failureTitle": { + "message": "Issues were logged in the `Issues` panel in Chrome Devtools" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | issueTypeBlockedByResponse": { + "message": "Blocked by cross-origin policy" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | issueTypeHeavyAds": { + "message": "Heavy resource usage by ads" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | title": { + "message": "No issues in the `Issues` panel in Chrome Devtools" + }, "lighthouse-core/audits/dobetterweb/js-libraries.js | columnVersion": { "message": "Version" }, @@ -752,9 +770,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Uses passive listeners to improve scrolling performance" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Description" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Errors logged to the console indicate unresolved problems. They can come from network request failures and other browser concerns. [Learn more](https://web.dev/errors-in-console/)" }, @@ -1616,6 +1631,9 @@ "lighthouse-core/lib/i18n/i18n.js | columnCacheTTL": { "message": "Cache TTL" }, + "lighthouse-core/lib/i18n/i18n.js | columnDescription": { + "message": "Description" + }, "lighthouse-core/lib/i18n/i18n.js | columnDuration": { "message": "Duration" }, diff --git a/lighthouse-core/lib/i18n/locales/en-XA.json b/lighthouse-core/lib/i18n/locales/en-XA.json index 3aa7ede9a98e..502571b27f26 100644 --- a/lighthouse-core/lib/i18n/locales/en-XA.json +++ b/lighthouse-core/lib/i18n/locales/en-XA.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "[Ûšéš þåššîvé ļîšţéñéŕš ţö îmþŕövé šçŕöļļîñĝ þéŕƒöŕmåñçé one two three four five six seven eight nine ten eleven]" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "[Ðéšçŕîþţîöñ one two]" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "[Éŕŕöŕš ļöĝĝéð ţö ţĥé çöñšöļé îñðîçåţé ûñŕéšöļvéð þŕöбļémš. Ţĥéý çåñ çömé ƒŕöm ñéţŵöŕķ ŕéqûéšţ ƒåîļûŕéš åñð öţĥéŕ бŕöŵšéŕ çöñçéŕñš. ᐅ[ᐊĻéåŕñ möŕéᐅ](https://web.dev/errors-in-console/)ᐊ one two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty twentyone twentytwo]" }, diff --git a/lighthouse-core/lib/i18n/locales/en-XL.json b/lighthouse-core/lib/i18n/locales/en-XL.json index 5b4ca31d5e78..e235dcab6251 100644 --- a/lighthouse-core/lib/i18n/locales/en-XL.json +++ b/lighthouse-core/lib/i18n/locales/en-XL.json @@ -665,6 +665,24 @@ "lighthouse-core/audits/dobetterweb/geolocation-on-start.js | title": { "message": "Âv́ôíd̂ś r̂éq̂úêśt̂ín̂ǵ t̂h́ê ǵêól̂óĉát̂íôń p̂ér̂ḿîśŝíôń ôń p̂áĝé l̂óâd́" }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | columnIssueType": { + "message": "Îśŝúê t́ŷṕê" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | description": { + "message": "Îśŝúêś l̂óĝǵêd́ t̂ó t̂h́ê `Issues` ṕâńêĺ îń Ĉh́r̂óm̂é D̂év̂t́ôól̂ś îńd̂íĉát̂é ûńr̂éŝól̂v́êd́ p̂ŕôb́l̂ém̂ś. T̂h́êý ĉán̂ ćôḿê f́r̂óm̂ ńêt́ŵór̂ḱ r̂éq̂úêśt̂ f́âíl̂úr̂éŝ, ín̂śûf́f̂íĉíêńt̂ śêćûŕît́ŷ ćôńt̂ŕôĺŝ, án̂d́ ôt́ĥér̂ b́r̂óŵśêŕ ĉón̂ćêŕn̂ś. Ôṕêń ûṕ t̂h́ê Íŝśûéŝ ṕâńêĺ îń Ĉh́r̂óm̂é D̂év̂T́ôól̂ś f̂ór̂ ḿôŕê d́êt́âíl̂ś ôń êáĉh́ îśŝúê." + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | failureTitle": { + "message": "Îśŝúêś ŵér̂é l̂óĝǵêd́ îń t̂h́ê `Issues` ṕâńêĺ îń Ĉh́r̂óm̂é D̂év̂t́ôól̂ś" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | issueTypeBlockedByResponse": { + "message": "B̂ĺôćk̂éd̂ b́ŷ ćr̂óŝś-ôŕîǵîń p̂ól̂íĉý" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | issueTypeHeavyAds": { + "message": "Ĥéâv́ŷ ŕêśôúr̂ćê úŝáĝé b̂ý âd́ŝ" + }, + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | title": { + "message": "N̂ó îśŝúêś îń t̂h́ê `Issues` ṕâńêĺ îń Ĉh́r̂óm̂é D̂év̂t́ôól̂ś" + }, "lighthouse-core/audits/dobetterweb/js-libraries.js | columnVersion": { "message": "V̂ér̂śîón̂" }, @@ -752,9 +770,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Ûśêś p̂áŝśîv́ê ĺîśt̂én̂ér̂ś t̂ó îḿp̂ŕôv́ê śĉŕôĺl̂ín̂ǵ p̂ér̂f́ôŕm̂án̂ćê" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "D̂éŝćr̂íp̂t́îón̂" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Êŕr̂ór̂ś l̂óĝǵêd́ t̂ó t̂h́ê ćôńŝól̂é îńd̂íĉát̂é ûńr̂éŝól̂v́êd́ p̂ŕôb́l̂ém̂ś. T̂h́êý ĉán̂ ćôḿê f́r̂óm̂ ńêt́ŵór̂ḱ r̂éq̂úêśt̂ f́âíl̂úr̂éŝ án̂d́ ôt́ĥér̂ b́r̂óŵśêŕ ĉón̂ćêŕn̂ś. [L̂éâŕn̂ ḿôŕê](https://web.dev/errors-in-console/)" }, @@ -1616,6 +1631,9 @@ "lighthouse-core/lib/i18n/i18n.js | columnCacheTTL": { "message": "Ĉáĉh́ê T́T̂Ĺ" }, + "lighthouse-core/lib/i18n/i18n.js | columnDescription": { + "message": "D̂éŝćr̂íp̂t́îón̂" + }, "lighthouse-core/lib/i18n/i18n.js | columnDuration": { "message": "D̂úr̂át̂íôń" }, diff --git a/lighthouse-core/lib/i18n/locales/es-419.json b/lighthouse-core/lib/i18n/locales/es-419.json index d3688473a910..fde50fd91aec 100644 --- a/lighthouse-core/lib/i18n/locales/es-419.json +++ b/lighthouse-core/lib/i18n/locales/es-419.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Usa objetos de escucha pasivos para mejorar el rendimiento del desplazamiento" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descripción" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Los errores registrados en la consola indican la existencia de problemas no resueltos. Es posible que se deban a problemas con solicitudes de red y otros relativos al navegador. [Obtén más información](https://web.dev/errors-in-console/)." }, diff --git a/lighthouse-core/lib/i18n/locales/es.json b/lighthouse-core/lib/i18n/locales/es.json index 1e8f57b44fa0..c72e11504373 100644 --- a/lighthouse-core/lib/i18n/locales/es.json +++ b/lighthouse-core/lib/i18n/locales/es.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Usa listeners pasivos para mejorar el desplazamiento" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descripción" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Los errores registrados en la consola indican que hay problemas sin resolver. Pueden proceder de solicitudes fallidas de la red y otros errores del navegador. [Más información](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/fi.json b/lighthouse-core/lib/i18n/locales/fi.json index 61368a179ae9..863f3b7f56a3 100644 --- a/lighthouse-core/lib/i18n/locales/fi.json +++ b/lighthouse-core/lib/i18n/locales/fi.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Käyttää passiivisia seuraimia vieritystoiminnan parantamiseen" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Kuvaus" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Konsoliin kirjatut virheet viittaavat ratkaisemattomiin ongelmiin. Ne voivat johtua epäonnistuneista verkkopyynnöistä ja muista selainongelmista. [Lue lisää](https://web.dev/errors-in-console/)." }, diff --git a/lighthouse-core/lib/i18n/locales/fil.json b/lighthouse-core/lib/i18n/locales/fil.json index 1e415d566e34..8096aaefb890 100644 --- a/lighthouse-core/lib/i18n/locales/fil.json +++ b/lighthouse-core/lib/i18n/locales/fil.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Gumagamit ng mga passive na listener para pahusayin ang performance sa pag-scroll" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Paglalarawan" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Nagsasaad ng mga hindi naresolbang problema ang mga error na naka-log sa console. Puwedeng manggaling ang mga ito sa mga hindi nagawang kahilingan sa network at iba pang alalahanin sa browser. [Matuto pa](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/fr.json b/lighthouse-core/lib/i18n/locales/fr.json index 23d2b39a6e48..66e9faeb1207 100644 --- a/lighthouse-core/lib/i18n/locales/fr.json +++ b/lighthouse-core/lib/i18n/locales/fr.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "La page utilise des écouteurs d'événements passifs pour améliorer les performances de défilement" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Description" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Les erreurs enregistrées dans la console indiquent des problèmes non résolus. Ces derniers peuvent être dus à des requêtes réseau qui ont échoué et à d'autres problèmes du navigateur. [En savoir plus](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/he.json b/lighthouse-core/lib/i18n/locales/he.json index 2093b02c58f8..3c278e9bf4ee 100644 --- a/lighthouse-core/lib/i18n/locales/he.json +++ b/lighthouse-core/lib/i18n/locales/he.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "נעשה שימוש ברכיבי listener פסיביים לשיפור ביצועי הגלילה" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "תיאור" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "שגיאות שנרשמו במסוף מצביעות על בעיות לא פתורות. הן עשויות להופיע בעקבות כשל בבקשות ברשת או בעיות אחרות בדפדפן. [מידע נוסף](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/hi.json b/lighthouse-core/lib/i18n/locales/hi.json index 7db1e1f841cb..2c0eb5b74f14 100644 --- a/lighthouse-core/lib/i18n/locales/hi.json +++ b/lighthouse-core/lib/i18n/locales/hi.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "पैसिव श्रोताओं की मदद से स्क्रोल परफ़ॉर्मेंस बेहतर की जाती है" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "ब्यौरा" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "कंसोल में लॉग की गई गड़बड़ियां उन मुश्किलों की तरफ़ इशारा करती हैं जिनका समाधान किया जाना अभी बाकी है. ये गड़बड़ियां, नेटवर्क अनुरोधों के काम न करने और ब्राउज़र से जुड़ी दूसरी वजहों से हो सकती हैं. [ज़्यादा जानें](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/hr.json b/lighthouse-core/lib/i18n/locales/hr.json index 8af624ddbabd..f819a0216b7a 100644 --- a/lighthouse-core/lib/i18n/locales/hr.json +++ b/lighthouse-core/lib/i18n/locales/hr.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Upotrebljava pasivne osluškivače za unaprjeđenje rezultata pretraživanja" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Opis" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Pogreške zabilježene u konzoli ukazuju na neriješene probleme. Rezultat su neuspjelih mrežnih zahtjeva i ostalih pitanja povezanih s preglednikom. [Saznajte više](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/hu.json b/lighthouse-core/lib/i18n/locales/hu.json index 590a4dddff96..8f6348ba91f1 100644 --- a/lighthouse-core/lib/i18n/locales/hu.json +++ b/lighthouse-core/lib/i18n/locales/hu.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Passzív figyelőket alkalmaz a görgetés teljesítményének javításához" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Leírás" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "A konzolon megjelenő hibák megoldatlan problémákat jeleznek. Okaik lehetnek sikertelen hálózati kérések, valamint más böngészős tényezők is. [További információ](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/id.json b/lighthouse-core/lib/i18n/locales/id.json index 1559262ea569..2956cfe90f78 100644 --- a/lighthouse-core/lib/i18n/locales/id.json +++ b/lighthouse-core/lib/i18n/locales/id.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Menggunakan pemroses pasif untuk menyempurnakan performa scroll" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Deskripsi" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Error yang dicatat di konsol menunjukkan masalah yang belum terselesaikan. Error dapat berasal dari permintaan jaringan yang gagal dan masalah browser lainnya. [Pelajari lebih lanjut](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/it.json b/lighthouse-core/lib/i18n/locales/it.json index 7980f11c69f8..c6f6a72bd76f 100644 --- a/lighthouse-core/lib/i18n/locales/it.json +++ b/lighthouse-core/lib/i18n/locales/it.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Usa listener passivi per migliorare le prestazioni dello scorrimento" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descrizione" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Gli errori registrati nella console indicano la presenza di problemi irrisolti che potrebbero riguardare richieste di rete non andate a buon fine e altri problemi del browser. [Ulteriori informazioni](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ja.json b/lighthouse-core/lib/i18n/locales/ja.json index 391277ebc6e8..0eac1e207099 100644 --- a/lighthouse-core/lib/i18n/locales/ja.json +++ b/lighthouse-core/lib/i18n/locales/ja.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "スクロール パフォーマンスを高める受動的なリスナーが使用されています" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "説明" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "コンソールに記録されたエラーは未解決の問題を表します。これらはネットワーク リクエストの失敗や他のブラウザの問題が原因で表示される可能性があります。[詳細](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ko.json b/lighthouse-core/lib/i18n/locales/ko.json index 206f38191da6..8575a3ad2976 100644 --- a/lighthouse-core/lib/i18n/locales/ko.json +++ b/lighthouse-core/lib/i18n/locales/ko.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "스크롤 성능 개선에 패시브 리스너 사용" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "설명" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "콘솔에 로그된 오류는 해결되지 않은 문제를 의미합니다. 네트워크 요청 실패를 비롯한 기타 브라우저 문제로 인해 발생할 수 있습니다. [자세히 알아보기](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/lt.json b/lighthouse-core/lib/i18n/locales/lt.json index 41f27baedf63..28d78d46d635 100644 --- a/lighthouse-core/lib/i18n/locales/lt.json +++ b/lighthouse-core/lib/i18n/locales/lt.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Naudojamos pasyvios apdorojimo priemonės siekiant pagerinti slinkimo našumą" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Aprašas" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Pulte užregistruotos klaidos nurodo, kad esama neišspręstų problemų. Jos galėjo kilti nepavykus pateikti tinklo užklausų arba dėl kitų naršyklės problemų. [Sužinokite daugiau](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/lv.json b/lighthouse-core/lib/i18n/locales/lv.json index a1dfa92771d7..e904ad030dd6 100644 --- a/lighthouse-core/lib/i18n/locales/lv.json +++ b/lighthouse-core/lib/i18n/locales/lv.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Tiek izmantoti pasīvie klausītāji, lai uzlabotu ritināšanas veiktspēju" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Apraksts" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Konsolē reģistrētās kļūdas norāda uz neatrisinātām problēmām. Tās var rasties no tīkla pieprasījuma kļūmēm un citām pārlūkprogrammas problēmām. [Uzzināt vairāk](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/nl.json b/lighthouse-core/lib/i18n/locales/nl.json index 64c43ddb6dd4..5e60467c4e14 100644 --- a/lighthouse-core/lib/i18n/locales/nl.json +++ b/lighthouse-core/lib/i18n/locales/nl.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Gebruikt passieve listeners voor de verbetering van de scrollprestaties" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Beschrijving" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Fouten die op de console worden geregistreerd, geven aan dat er onopgeloste problemen zijn. Ze kunnen afkomstig zijn van niet-uitgevoerde netwerkverzoeken en andere problemen met de browser. [Meer informatie](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/no.json b/lighthouse-core/lib/i18n/locales/no.json index 801d50089d5b..0224e415a4e4 100644 --- a/lighthouse-core/lib/i18n/locales/no.json +++ b/lighthouse-core/lib/i18n/locales/no.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Bruker passive lyttere for å oppnå bedre ytelse ved rulling på siden" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Beskrivelse" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Feil som loggføres i konsollen, tyder på uløste problemer. De kan stamme fra mislykkede nettverksforespørsler og andre nettleserproblemer. [Finn ut mer](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/pl.json b/lighthouse-core/lib/i18n/locales/pl.json index 8ebdbe9297a4..2a3504a006f8 100644 --- a/lighthouse-core/lib/i18n/locales/pl.json +++ b/lighthouse-core/lib/i18n/locales/pl.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Używa detektorów pasywnych do poprawy działania przewijania" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Opis" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Błędy zarejestrowane w konsoli wskazują na nierozwiązane problemy. Mogą być spowodowane nieudanymi żądaniami sieciowymi i innymi problemami w przeglądarce. [Więcej informacji](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/pt-PT.json b/lighthouse-core/lib/i18n/locales/pt-PT.json index e7c7aaa83c9a..22135e0aa851 100644 --- a/lighthouse-core/lib/i18n/locales/pt-PT.json +++ b/lighthouse-core/lib/i18n/locales/pt-PT.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Utiliza ouvintes passivos para melhorar o desempenho do deslocamento" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descrição" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Os erros registados na consola indicam problemas não resolvidos. Estes podem ser provenientes de falhas de pedidos de rede e outras questões do navegador. [Saiba mais](https://web.dev/errors-in-console/)." }, diff --git a/lighthouse-core/lib/i18n/locales/pt.json b/lighthouse-core/lib/i18n/locales/pt.json index 15b83f8cb61a..cd97fb5900f0 100644 --- a/lighthouse-core/lib/i18n/locales/pt.json +++ b/lighthouse-core/lib/i18n/locales/pt.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Utiliza listeners passivos para melhorar o desempenho de rolagem" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descrição" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Os erros registrados no console indicam problemas não resolvidos. Eles podem ocorrer devido a falhas de solicitação de rede e outras questões relacionadas ao navegador. [Saiba mais](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ro.json b/lighthouse-core/lib/i18n/locales/ro.json index f2760def9c9e..f268e5a2a212 100644 --- a/lighthouse-core/lib/i18n/locales/ro.json +++ b/lighthouse-core/lib/i18n/locales/ro.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Folosește ascultători pasivi pentru a îmbunătăți performanța la derulare" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Descriere" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Erorile înregistrate pe consolă indică probleme nerezolvate Acestea pot fi provocate de erorile de solicitare din rețea și de alte probleme ale browserului. [Află mai multe](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ru.json b/lighthouse-core/lib/i18n/locales/ru.json index e3a0954e6e1a..af975fe764ac 100644 --- a/lighthouse-core/lib/i18n/locales/ru.json +++ b/lighthouse-core/lib/i18n/locales/ru.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Пассивные прослушиватели событий используются для улучшения производительности при прокрутке" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Описание" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Ошибки, записанные в журнале консоли, указывают на нерешенные проблемы. Это могут быть невыполненные сетевые запросы и другие сбои в работе браузера. [Подробнее…](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/sk.json b/lighthouse-core/lib/i18n/locales/sk.json index 0731ee6fcb88..70a1bb1cac77 100644 --- a/lighthouse-core/lib/i18n/locales/sk.json +++ b/lighthouse-core/lib/i18n/locales/sk.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Používa pasívne prijímače na zlepšenie posúvania" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Popis" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Chyby zapísané do denníka konzoly označujú nevyriešené problémy. Môžu pochádzať zo zlyhaní žiadostí siete a ďalších problémov prehliadača. [Ďalšie informácie](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/sl.json b/lighthouse-core/lib/i18n/locales/sl.json index 10f2aa2a9967..2a67ccb1101c 100644 --- a/lighthouse-core/lib/i18n/locales/sl.json +++ b/lighthouse-core/lib/i18n/locales/sl.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Uporablja pasivne poslušalce za izboljšanje delovanja pomikanja" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Opis" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Napake, zabeležene v konzoli, označujejo nerazrešene težave. Te so lahko posledica neuspešnih omrežnih zahtev in drugih težav z brskalnikom. [Več o tem](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/sr-Latn.json b/lighthouse-core/lib/i18n/locales/sr-Latn.json index 5bcddac0abbd..00d598cf4ab8 100644 --- a/lighthouse-core/lib/i18n/locales/sr-Latn.json +++ b/lighthouse-core/lib/i18n/locales/sr-Latn.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Koristite pasivne obrađivače da biste poboljšali učinak pomeranja" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Opis" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Greške evidentirane u konzoli ukazuju na nerešene probleme. One su rezultat neuspelih mrežnih zahteva i drugih problema u vezi sa pregledačem. [Saznajte više](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/sr.json b/lighthouse-core/lib/i18n/locales/sr.json index 99381823eb7a..85738be17489 100644 --- a/lighthouse-core/lib/i18n/locales/sr.json +++ b/lighthouse-core/lib/i18n/locales/sr.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Користите пасивне обрађиваче да бисте побољшали учинак померања" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Опис" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Грешке евидентиране у конзоли указују на нерешене проблеме. Оне су резултат неуспелих мрежних захтева и других проблема у вези са прегледачем. [Сазнајте више](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/sv.json b/lighthouse-core/lib/i18n/locales/sv.json index 48c240e9c6ef..47d50fd672e3 100644 --- a/lighthouse-core/lib/i18n/locales/sv.json +++ b/lighthouse-core/lib/i18n/locales/sv.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Passiva lyssnare används för att förbättra rullningsprestanda" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Beskrivning" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Fel som loggats i konsolen indikerar olösta problem. De kan bero på fel i nätverksförfrågningar och andra webbläsarproblem. [Läs mer](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/ta.json b/lighthouse-core/lib/i18n/locales/ta.json index 222f0bd7f457..31f818d3b40a 100644 --- a/lighthouse-core/lib/i18n/locales/ta.json +++ b/lighthouse-core/lib/i18n/locales/ta.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "நகர்த்துதல் செயல்திறனை மேம்படுத்துவதற்காக பேசிவ் லிசனர்களைப் பயன்படுத்துகின்றன" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "விளக்கம்" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "கன்சோலில் பதிவுசெய்யப்பட்ட பிழைகள் தீர்க்கப்படாத சிக்கல்களைக் குறிக்கின்றன. அவை நெட்வொர்க் கோரிக்கை பிழைகளினாலும் வேறு உலாவி சிக்கல்களினாலும் ஏற்பட்டிருக்கும். [மேலும் அறிக](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/te.json b/lighthouse-core/lib/i18n/locales/te.json index 8b31a6eaf600..93eb61cc907b 100644 --- a/lighthouse-core/lib/i18n/locales/te.json +++ b/lighthouse-core/lib/i18n/locales/te.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "స్క్రోలింగ్ పనితీరును మెరుగుపరచడానికి పాసివ్ లిజనర్‌లను వినియోగిస్తుంది" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "వివరణ" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "కన్సోల్‌లో లాగ్ చేయబడిన ఎర్రర్‌లు పరిష్కారం కాని సమస్యలను సూచిస్తాయి. నెట్‌వర్క్ అభ్యర్థన వైఫల్యాలు, ఇతర బ్రౌజర్ ఇబ్బందుల వలన అవి ఏర్పడి ఉంటాయి. [మరింత తెలుసుకోండి](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/th.json b/lighthouse-core/lib/i18n/locales/th.json index a3366d275431..8215f2b505ed 100644 --- a/lighthouse-core/lib/i18n/locales/th.json +++ b/lighthouse-core/lib/i18n/locales/th.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "ใช้ Listener แบบแพสซีฟเพื่อปรับปรุงประสิทธิภาพการเลื่อน" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "รายละเอียด" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "ข้อผิดพลาดที่บันทึกลงในคอนโซลแสดงให้เห็นถึงปัญหาที่ไม่ได้รับการแก้ไข ข้อผิดพลาดอาจมาจากคำขอเครือข่ายที่ไม่สำเร็จ และปัญหาอื่นๆ เกี่ยวกับเบราว์เซอร์ [ดูข้อมูลเพิ่มเติม](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/tr.json b/lighthouse-core/lib/i18n/locales/tr.json index 62f63cbeb13e..c978ab8852d6 100644 --- a/lighthouse-core/lib/i18n/locales/tr.json +++ b/lighthouse-core/lib/i18n/locales/tr.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Kaydırma performansını artırmak için pasif işleyicileri kullanıyor" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Açıklama" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Konsola kaydedilen hatalar çözülmemiş problemleri belirtir Bunlar, ağ istek hatalarından ve diğer tarayıcı sorunlarından gelebilir. [Daha fazla bilgi](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/uk.json b/lighthouse-core/lib/i18n/locales/uk.json index baea16e4fc4e..01521f3efb24 100644 --- a/lighthouse-core/lib/i18n/locales/uk.json +++ b/lighthouse-core/lib/i18n/locales/uk.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Використовує пасивні прослуховувачі, щоб покращити прокручування сторінки" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Опис" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Помилки, записані в журнал консолі, указують на невирішені проблеми. Вони можуть бути викликані збоями запитів мережі або іншими проблемами веб-переглядача. [Докладніше](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/vi.json b/lighthouse-core/lib/i18n/locales/vi.json index 6bfd43ba4d98..3d0825036620 100644 --- a/lighthouse-core/lib/i18n/locales/vi.json +++ b/lighthouse-core/lib/i18n/locales/vi.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "Sử dụng trình nghe bị động để cải thiện hiệu suất cuộn" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "Nội dung mô tả" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "Các lỗi được ghi vào bảng điều khiển là những sự cố chưa giải quyết. Những sự cố này có thể do lỗi yêu cầu mạng và các vấn đề khác của trình duyệt gây ra. [Tìm hiểu thêm](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/zh-HK.json b/lighthouse-core/lib/i18n/locales/zh-HK.json index ea9cd1c36ece..6b4586efed39 100644 --- a/lighthouse-core/lib/i18n/locales/zh-HK.json +++ b/lighthouse-core/lib/i18n/locales/zh-HK.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "使用被動活動監聽器來提升捲動效能" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "說明" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "如果管理中心有錯誤記錄,表示系統仍有問題尚待解決,例如網絡要求錯誤和其他瀏覽器問題。[瞭解詳情](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/zh-TW.json b/lighthouse-core/lib/i18n/locales/zh-TW.json index 77af4c6cf911..304a3e921a74 100644 --- a/lighthouse-core/lib/i18n/locales/zh-TW.json +++ b/lighthouse-core/lib/i18n/locales/zh-TW.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "使用被動事件監聽器來提升捲動效能" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "說明" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "如果主控台有錯誤記錄,表示系統有問題尚待解決,例如網路要求錯誤和其他瀏覽器問題。[瞭解詳情](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/lib/i18n/locales/zh.json b/lighthouse-core/lib/i18n/locales/zh.json index eb597b638a53..25d9fdd2a879 100644 --- a/lighthouse-core/lib/i18n/locales/zh.json +++ b/lighthouse-core/lib/i18n/locales/zh.json @@ -752,9 +752,6 @@ "lighthouse-core/audits/dobetterweb/uses-passive-event-listeners.js | title": { "message": "使用被动式监听器来提高滚动性能" }, - "lighthouse-core/audits/errors-in-console.js | columnDesc": { - "message": "说明" - }, "lighthouse-core/audits/errors-in-console.js | description": { "message": "控制台中记录的错误表明有未解决的问题。导致这些错误的可能原因是网络请求失败和其他浏览器问题。[了解详情](https://web.dev/errors-in-console/)" }, diff --git a/lighthouse-core/test/audits/dobetterweb/has-inspector-issues-test.js b/lighthouse-core/test/audits/dobetterweb/has-inspector-issues-test.js new file mode 100644 index 000000000000..82fb0ad05a24 --- /dev/null +++ b/lighthouse-core/test/audits/dobetterweb/has-inspector-issues-test.js @@ -0,0 +1,248 @@ +/** + * @license Copyright 2020 The Lighthouse Authors. All Rights Reserved. + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + */ +'use strict'; + +const InspectorIssuesAudit = + require('../../../audits/dobetterweb/has-inspector-issues.js'); + +/* eslint-env jest */ + +describe('Has inspector issues audit', () => { + let issues; + beforeEach(() => { + issues = { + mixedContent: [], + sameSiteCookies: [], + blockedByResponse: [], + heavyAds: [], + contentSecurityPolicy: [], + }; + }); + + it('passes when no issues are found', () => { + const auditResult = InspectorIssuesAudit.audit({ + InspectorIssues: issues, + }); + expect(auditResult.score).toBe(1); + expect(auditResult.details.items).toHaveLength(0); + }); + + it('correctly displays mixed content issues', () => { + const mixedContentIssues = [ + { + resolutionStatus: 'MixedContentBlocked', + insecureURL: 'www.mixedcontent.com', + mainResourceURL: 'www.mixedcontent.com', + }, + { + resolutionStatus: 'MixedContentWarning', + insecureURL: 'www.insecureurl.com', + mainResourceURL: 'www.inscureurl.com', + request: { + requestId: '1', + url: 'www.insecureurl.com/request', + }, + }, + ]; + issues.mixedContent.push(...mixedContentIssues); + + const auditResult = InspectorIssuesAudit.audit({ + InspectorIssues: issues, + }); + expect(auditResult.score).toBe(0); + expect(auditResult.details.items[0]).toMatchObject({ + issueType: 'Mixed content', + subItems: { + type: 'subitems', + items: [ + { + // Fell back to `mainResourceURL` since no `request`. + url: 'www.mixedcontent.com', + }, + { + url: 'www.insecureurl.com/request', + }, + ], + }, + }); + }); + + it('correctly displays SameSite cookie issues', () => { + const samesiteIssues = [ + { + cookieUrl: 'www.samesitecookies.com', + }, + { + request: { + requestId: '2', + url: 'www.samesiterequest.com', + }, + }, + ]; + issues.sameSiteCookies.push(...samesiteIssues); + + const auditResult = InspectorIssuesAudit.audit({ + InspectorIssues: issues, + }); + expect(auditResult.score).toBe(0); + expect(auditResult.details.items[0]).toMatchObject({ + issueType: 'SameSite cookie', + subItems: { + type: 'subitems', + items: [ + { + // Fell back to `mainResourceURL` since no `request`. + url: 'www.samesitecookies.com', + }, + { + url: 'www.samesiterequest.com', + }, + ], + }, + }); + }); + + it('correctly displays Blocked By Response issues', () => { + const blockedByResponseIssues = [ + { + reason: 'CoepFrameResourceNeedsCoepHeader', + request: { + url: 'www.coep.com', + }, + }, + { + reason: 'CoopSandboxedIFrameCannotNavigateToCoopPage', + request: { + url: 'www.coop.com', + }, + }, + { + reason: 'CorpNotSameOriginAfterDefaultedToSameOriginByCoep', + request: { + requestId: '3', + }, + }, + { + reason: 'CorpNotSameOrigin', + request: { + url: 'www.same-origin.com', + }, + }, + { + reason: 'CorpNotSameSite', + request: { + url: 'www.same-site.com', + }, + }, + ]; + issues.blockedByResponse.push(...blockedByResponseIssues); + + const auditResult = InspectorIssuesAudit.audit({ + InspectorIssues: issues, + }); + expect(auditResult.score).toBe(0); + expect(auditResult.details.items[0]).toMatchObject({ + issueType: { + formattedDefault: 'Blocked by cross-origin policy', + }, + subItems: { + type: 'subitems', + // should only be 4 subitems as one of the issues doesn't have a request url + items: [ + { + url: 'www.coep.com', + }, + { + url: 'www.coop.com', + }, + { + url: 'www.same-origin.com', + }, + { + url: 'www.same-site.com', + }, + ], + }, + }); + }); + + it('correctly displays Heavy Ads issues', () => { + const heavyAdsIssues = [ + { + resolution: 'HeavyAdBlocked', + reason: 'NetworkTotalLimit', + }, + { + resolution: 'HeavyAdBlocked', + reason: 'CpuTotalLimit', + }, + { + resolution: 'HeavyAdBlocked', + reason: 'CpuPeakLimit', + }, + ]; + issues.heavyAds.push(...heavyAdsIssues); + + const auditResult = InspectorIssuesAudit.audit({ + InspectorIssues: issues, + }); + expect(auditResult.score).toBe(0); + expect(auditResult.details.items[0]).toMatchObject({ + issueType: { + formattedDefault: 'Heavy resource usage by ads', + }, + }); + }); + + it('correctly displays Content Security Policy issues', () => { + const cspIssues = [ + { + contentSecurityPolicyViolationType: 'kInlineViolation', + blockedURL: 'www.csp.com/inline-violation', + }, + { + contentSecurityPolicyViolationType: 'kEvalViolation', + blockedURL: 'www.csp.com/eval-violation', + }, + { + contentSecurityPolicyViolationType: 'kURLViolation', + blockedURL: 'www.csp.com/url-violation', + }, + // These last two should be filtered out as they aren't supported yet + { + contentSecurityPolicyViolationType: 'kTrustedTypesSinkViolation', + blockedURL: 'www.csp.com/sink-violation', + }, + { + contentSecurityPolicyViolationType: 'kTrustedTypesPolicyViolation', + blockedURL: 'www.csp.com/policy-violation', + }, + ]; + issues.contentSecurityPolicy.push(...cspIssues); + + const auditResult = InspectorIssuesAudit.audit({ + InspectorIssues: issues, + }); + expect(auditResult.score).toBe(0); + expect(auditResult.details.items[0]).toMatchObject({ + issueType: 'Content security policy', + subItems: { + type: 'subitems', + items: [ + { + url: 'www.csp.com/inline-violation', + }, + { + url: 'www.csp.com/eval-violation', + }, + { + url: 'www.csp.com/url-violation', + }, + ], + }, + }); + }); +}); diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index d1a78fb291fb..0e03dfd0a9b7 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -3758,6 +3758,14 @@ ] } }, + "has-inspector-issues": { + "id": "has-inspector-issues", + "title": "No issues in the `Issues` panel in Chrome Devtools", + "description": "Issues logged to the `Issues` panel in Chrome Devtools indicate unresolved problems. They can come from network request failures, insufficient security controls, and other browser concerns. Open up the Issues panel in Chrome DevTools for more details on each issue.", + "score": null, + "scoreDisplayMode": "error", + "errorMessage": "Cannot read property 'length' of undefined" + }, "no-document-write": { "id": "no-document-write", "title": "Avoid `document.write()`", @@ -5044,10 +5052,15 @@ "id": "valid-source-maps", "weight": 0, "group": "best-practices-general" + }, + { + "id": "has-inspector-issues", + "weight": 1, + "group": "best-practices-general" } ], "id": "best-practices", - "score": 0.07 + "score": null }, "seo": { "title": "SEO", @@ -6358,6 +6371,12 @@ "duration": 100, "entryType": "measure" }, + { + "startTime": 0, + "name": "lh:audit:has-inspector-issues", + "duration": 100, + "entryType": "measure" + }, { "startTime": 0, "name": "lh:audit:no-document-write", @@ -6754,7 +6773,7 @@ "audits[uses-http2].details.headings[0].label", "audits[uses-passive-event-listeners].details.headings[0].text" ], - "lighthouse-core/audits/errors-in-console.js | columnDesc": [ + "lighthouse-core/lib/i18n/i18n.js | columnDescription": [ "audits[errors-in-console].details.headings[1].text" ], "lighthouse-core/audits/server-response-time.js | title": [ @@ -7725,6 +7744,12 @@ "audits[notification-on-start].details.headings[1].text", "audits[uses-passive-event-listeners].details.headings[1].text" ], + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | title": [ + "audits[has-inspector-issues].title" + ], + "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | description": [ + "audits[has-inspector-issues].description" + ], "lighthouse-core/audits/dobetterweb/no-document-write.js | failureTitle": [ "audits[no-document-write].title" ], diff --git a/package.json b/package.json index d63d6ea8c5a5..99d66ce28242 100644 --- a/package.json +++ b/package.json @@ -125,7 +125,7 @@ "cross-env": "^7.0.2", "csv-validator": "^0.0.3", "cz-customizable": "^5.2.0", - "devtools-protocol": "0.0.801017", + "devtools-protocol": "0.0.805376", "eslint": "^4.19.1", "eslint-config-google": "^0.9.1", "eslint-plugin-local-rules": "0.1.0", diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt index 30b8393bfba4..57304d5d24dc 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt @@ -2,11 +2,11 @@ Tests that exporting works. ++++++++ testExportHtml -# of .lh-audit divs (original): 135 +# of .lh-audit divs (original): 136 -# of .lh-audit divs (exported html): 135 +# of .lh-audit divs (exported html): 136 ++++++++ testExportJson -# of audits (json): 151 +# of audits (json): 152 diff --git a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt index 1206b14b6bd9..ab129df9602b 100644 --- a/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt +++ b/third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt @@ -329,6 +329,7 @@ Auditing: Properly defines charset Auditing: Avoids an excessive DOM size Auditing: Links to cross-origin destinations are safe Auditing: Avoids requesting the geolocation permission on page load +Auditing: No issues in the `Issues` panel in Chrome Devtools Auditing: Avoids `document.write()` Auditing: Avoids front-end JavaScript libraries with known security vulnerabilities Auditing: Detected JavaScript libraries @@ -457,6 +458,7 @@ form-field-multiple-labels: notApplicable frame-title: notApplicable geolocation-on-start: pass gpt-bids-parallel: notApplicable +has-inspector-issues: pass heading-order: notApplicable hreflang: pass html-has-lang: fail @@ -564,5 +566,5 @@ visual-order-follows-dom: manual without-javascript: pass works-offline: fail -# of .lh-audit divs: 155 +# of .lh-audit divs: 156 diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts index 5035c70875c1..cf5e71198bed 100644 --- a/types/artifacts.d.ts +++ b/types/artifacts.d.ts @@ -513,6 +513,10 @@ declare global { export interface InspectorIssues { mixedContent: Crdp.Audits.MixedContentIssueDetails[]; + sameSiteCookies: Crdp.Audits.SameSiteCookieIssueDetails[]; + blockedByResponse: Crdp.Audits.BlockedByResponseIssueDetails[]; + heavyAds: Crdp.Audits.HeavyAdIssueDetails[]; + contentSecurityPolicy: Crdp.Audits.ContentSecurityPolicyIssueDetails[]; } // Computed artifact types below. diff --git a/yarn.lock b/yarn.lock index 1d59e49f79a2..33ff7e487e71 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2619,10 +2619,10 @@ detective@^5.0.2: defined "^1.0.0" minimist "^1.1.1" -devtools-protocol@0.0.801017: - version "0.0.801017" - resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.801017.tgz#340754ebff17b73ddea1b15716ec53887261372c" - integrity sha512-vsOhv/pe1CV3yO3d8ZCRuLlu9FY0Kw4P5TVIC6htjyVfNeklCpFmUrEfvY0ju/y9dyAgwiOhe7pcreRh4/EaZw== +devtools-protocol@0.0.805376: + version "0.0.805376" + resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.805376.tgz#7ea29e412bfea69e9f2e77bcbafe83c898ad23bd" + integrity sha512-hZBiZTkVOAiWN7eI3oL1ftYtSi/HN8qn7/QYtDUNf9qVCG9/8pt+KyhL3Qoat6nXgiYiyreaz0mr6iB9Edw/sw== diff-sequences@^24.9.0: version "24.9.0"