From 7892760348bc82dac25349f1b83e0f0aaa561e77 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Tue, 7 Jun 2022 13:53:29 -0700 Subject: [PATCH] misc(build): fix lightrider report generator bundle (#14031) --- build/build-lightrider-bundles.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/build/build-lightrider-bundles.js b/build/build-lightrider-bundles.js index 50ae541e12d5..e69470221175 100644 --- a/build/build-lightrider-bundles.js +++ b/build/build-lightrider-bundles.js @@ -34,17 +34,22 @@ async function buildReportGenerator() { [`${LH_ROOT}/report/generator/flow-report-assets.js`]: 'export default {}', }), rollupPlugins.commonjs(), - rollupPlugins.nodeResolve(), rollupPlugins.inlineFs({verbose: Boolean(process.env.DEBUG)}), ], }); await bundle.write({ file: 'dist/lightrider/report-generator-bundle.js', - format: 'umd', + format: 'iife', name: 'ReportGenerator', }); await bundle.close(); + + // Typically one would use `umd` to export to the window object, but for some reason rollup + // adds a `require('fs')` when used above, which errors in google3 build. + const outPath = `${LH_ROOT}/dist/lightrider/report-generator-bundle.js`; + fs.writeFileSync(outPath, + fs.readFileSync(outPath, 'utf-8') + '\nwindow.ReportGenerator = ReportGenerator;\n'); } async function buildStaticServerBundle() {