From aa06403cd3a4a2a3eb007724dd8f442021aa8e3a Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Mon, 19 Nov 2018 20:50:23 -0800 Subject: [PATCH] sample json --- lighthouse-core/test/audits/service-worker-test.js | 1 + lighthouse-core/test/results/sample_v2.json | 5 ++--- proto/sample_v2_round_trip.json | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lighthouse-core/test/audits/service-worker-test.js b/lighthouse-core/test/audits/service-worker-test.js index 7f4c0a399e9c..da0a8b243e54 100644 --- a/lighthouse-core/test/audits/service-worker-test.js +++ b/lighthouse-core/test/audits/service-worker-test.js @@ -108,6 +108,7 @@ describe('Offline: service worker audit', () => { const swOpts = [{ status: 'activated', scriptURL: 'https://example.com/serviceworker/sw.js', + // can happen when 'Service-Worker-Allowed' header widens max scope. scopeURL: 'https://example.com/', }]; diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 053f381a53b9..2166a9ef4dbe 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -467,13 +467,12 @@ "score": 0, "scoreDisplayMode": "binary", "rawValue": false, - "explanation": "Failures: No manifest was fetched,\nSite does not register a service worker.", + "explanation": "Failures: No manifest was fetched.", "details": { "items": [ { "failures": [ - "No manifest was fetched", - "Site does not register a service worker" + "No manifest was fetched" ], "isParseFailure": true, "parseFailureReason": "No manifest was fetched" diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index 551bb7fb9f00..3ecd04f5039a 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -2548,15 +2548,14 @@ "items": [ { "failures": [ - "No manifest was fetched", - "Site does not register a service worker" + "No manifest was fetched" ], "isParseFailure": true, "parseFailureReason": "No manifest was fetched" } ] }, - "explanation": "Failures: No manifest was fetched,\nSite does not register a service worker.", + "explanation": "Failures: No manifest was fetched.", "id": "webapp-install-banner", "score": 0.0, "scoreDisplayMode": "binary",