From f0ffaca3dbf971e212ec6726f25e61105708168c Mon Sep 17 00:00:00 2001
From: Patrick Hulce <patrick.hulce@gmail.com>
Date: Thu, 8 Aug 2019 17:21:11 -0500
Subject: [PATCH] core(constants): increase default maxWaitForFcp to 30s
 (#9509)

---
 lighthouse-cli/test/cli/__snapshots__/index-test.js.snap | 4 ++--
 lighthouse-core/config/constants.js                      | 2 +-
 lighthouse-core/config/lr-desktop-config.js              | 1 +
 lighthouse-core/config/lr-mobile-config.js               | 1 +
 lighthouse-core/test/results/artifacts/artifacts.json    | 2 +-
 lighthouse-core/test/results/sample_v2.json              | 2 +-
 6 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
index dbb9cbc02830..5932fa49c441 100644
--- a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
+++ b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
@@ -1248,7 +1248,7 @@ Object {
     "extraHeaders": null,
     "gatherMode": false,
     "locale": "en-US",
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "onlyAudits": null,
     "onlyCategories": null,
@@ -1382,7 +1382,7 @@ Object {
     "extraHeaders": null,
     "gatherMode": false,
     "locale": "en-US",
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "onlyAudits": Array [
       "metrics",
diff --git a/lighthouse-core/config/constants.js b/lighthouse-core/config/constants.js
index 891c3fe32bcb..b65f63030428 100644
--- a/lighthouse-core/config/constants.js
+++ b/lighthouse-core/config/constants.js
@@ -43,7 +43,7 @@ const throttling = {
 /** @type {LH.Config.Settings} */
 const defaultSettings = {
   output: 'json',
-  maxWaitForFcp: 15 * 1000,
+  maxWaitForFcp: 30 * 1000,
   maxWaitForLoad: 45 * 1000,
   throttlingMethod: 'simulate',
   throttling: throttling.mobileSlow4G,
diff --git a/lighthouse-core/config/lr-desktop-config.js b/lighthouse-core/config/lr-desktop-config.js
index 8e0aa8f28a3e..e4de4934c262 100644
--- a/lighthouse-core/config/lr-desktop-config.js
+++ b/lighthouse-core/config/lr-desktop-config.js
@@ -9,6 +9,7 @@
 const config = {
   extends: 'lighthouse:default',
   settings: {
+    maxWaitForFcp: 15 * 1000,
     maxWaitForLoad: 35 * 1000,
     emulatedFormFactor: 'desktop',
     throttling: {
diff --git a/lighthouse-core/config/lr-mobile-config.js b/lighthouse-core/config/lr-mobile-config.js
index 2c689ad1bdae..03454c66764b 100644
--- a/lighthouse-core/config/lr-mobile-config.js
+++ b/lighthouse-core/config/lr-mobile-config.js
@@ -9,6 +9,7 @@
 const config = {
   extends: 'lighthouse:default',
   settings: {
+    maxWaitForFcp: 15 * 1000,
     maxWaitForLoad: 35 * 1000,
     // Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
     skipAudits: ['uses-http2'],
diff --git a/lighthouse-core/test/results/artifacts/artifacts.json b/lighthouse-core/test/results/artifacts/artifacts.json
index c038d4363e32..6ee5d32aa7c2 100644
--- a/lighthouse-core/test/results/artifacts/artifacts.json
+++ b/lighthouse-core/test/results/artifacts/artifacts.json
@@ -13,7 +13,7 @@
     "output": [
       "html"
     ],
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "throttlingMethod": "devtools",
     "throttling": {
diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
index 7a6622ca362e..983593e60a84 100644
--- a/lighthouse-core/test/results/sample_v2.json
+++ b/lighthouse-core/test/results/sample_v2.json
@@ -3246,7 +3246,7 @@
     "output": [
       "json"
     ],
-    "maxWaitForFcp": 15000,
+    "maxWaitForFcp": 30000,
     "maxWaitForLoad": 45000,
     "throttlingMethod": "devtools",
     "throttling": {