Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Manifest does not have short_name” failure even though the name is <12 characters #10044

Closed
westonruter opened this issue Nov 27, 2019 · 2 comments
Labels

Comments

@westonruter
Copy link

westonruter commented Nov 27, 2019

Provide the steps to reproduce

  1. Run LH PWA audit on https://elsoberano.org/

What is the current behavior?

The PWA audit flags the absence of short_name:

image

Nevertheless, the manifest has a name that is short already (11 characters): “El Soberano”.

The page still is offered to be installed as a PWA in Chrome, so this is not actually blocking the installability.

What is the expected behavior?

If the short_name is absent and the name is less than 12 characters (the recommended length) then nothing should be raised as an issue.

If the name is longer than 12 characters, then the Lighthouse audit should say something like, “The name is longer than 12 characters so a short_name is required.”

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: 5.2.0
  • Chrome version: 78.0.3904.108 (Official Build) (64-bit)
  • Operating System: MacOS
@connorjclark
Copy link
Collaborator

This makes sense to me. I understand Chrome and Firefox don't explicitly require a short_name, (or even a short name), so I don't quite understand why this is an "Installable" check. Also, feels safe to assume that no other PWA installable platforms are hard-checking this.

@westonruter westonruter changed the title "Manifest does not have short_name" failure even though the name is <12 characters “Manifest does not have short_name” failure even though the name is <12 characters Nov 27, 2019
@paulirish paulirish added the pwa label Apr 16, 2024
@adrianaixba
Copy link
Collaborator

As per Chrome’s updated Installability Criteria, Lighthouse will be deprecating the PWA category in the next upcoming release. For future PWA testing, users will be directed to use the updated PWA documentation. Marking this as closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants